WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#19788 closed defect (bug) (fixed)

i18 problems for Comment section

Reported by: pavelevap Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.3.1
Component: I18N Keywords: ux-feedback
Focuses: Cc:

Description

1) Function wp_comment_trashnotice() uses for example string "Comment by %s moved to the trash". Placeholder is for user, but in our translation this placeholder has to be in the end to make it sense, that means "... autorem byl %s." But there is problem with additonal space character which is inserted automatically by Javascript, so the string is "... autorem byl %s ." I tried to fix it, but not sure if I could broke anything else, so please look at attached patch.

2) I do not see the need to use list on help tab for Comments, it is also attached in this patch. I browsed related admin pages and there are lists only when there is colon in the first sentence. I am not sure, maybe it should be reformulated a bit...

3) There is following sentence in the help tab: "The small bubble with the number in it shows how many comments that post has received." But as I can see, number shows not all received comments, but only approved comments. I am not sure if Help text or number itself is wrong...

4) And the last one - there are some strings in Help and Comments section which refer to "Post", but comments can be added to Attachments, Pages, etc. Especially, link "View Post" is not very good, because it is highligted many times on this admin page, even if there are only attachments or books...

Attachments (2)

comments_i18n.patch (3.9 KB) - added by pavelevap 6 years ago.
19788.2.diff (2.2 KB) - added by lessbloat 5 years ago.

Download all attachments as: .zip

Change History (15)

#1 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.4
  • Owner set to nacin
  • Status changed from new to accepted

#2 @nacin
6 years ago

Point 1: Valid.

Point 2: Agreed.

Point 3: The bubble shows the number of approved comments, but is a highlight color if there are pending comments. The help text needs a small tweak.

Point 4: We have the view_item label, which defaults to "View Post" or "View Page". It should have been used here.

#3 @nacin
6 years ago

Check that, view_item *is* used there. While we should probably add a view_item for the attachment post type, I'm not sure what it should be. We call it "Attachment Post" ("Attachment Post URL") when inserting media, and "Attachment Page" when inserting a gallery. "View Attachment" seems okay in this context, though, as it's not like we're differentiating between the image itself and the page it is on.

#4 @nacin
6 years ago

  • Keywords ux-feedback added

Marking for review from Jane.

#5 @nacin
6 years ago

In [19804]:

Don't add in an extra space when inserting a name into the string produced by wp_comment_trashnotice(). props pavelevap, see #19788.

#6 @nacin
6 years ago

In [19806]:

Convert a bulleted list to paragraphs in the Moderating Comments help tab. props pavelevap, see #19788.

#7 follow-up: @SergeyBiryukov
6 years ago

Traced the extra space in point 1 to [12139].

#8 in reply to: ↑ 7 @nacin
6 years ago

Replying to SergeyBiryukov:

Traced the extra space in point 1 to [12139].

Likewise, but could not ascertain why it was added. When the helper was added earlier than that, see http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/template.php?rev=12008#L2362, it was not ideal for i18n but it would have put spaces on each side.

#9 follow-up: @nacin
6 years ago

For review from Jane:

  • The help text on the Comments screen says "The small bubble with the number in it shows how many comments that post has received." This is not accurate — the bubble shows the number of approved comments only. It is highlighted blue if there are pending comments. What should the new help text say?
  • On the Comments screen, it says "View Post" or "View Page" in the right column. For comments on attachments, should it say "View Attachment"? "View Attachment Page"? "View Attachment Post"?

#10 @ryan
6 years ago

  • Milestone changed from 3.4 to Future Release

#11 @ocean90
5 years ago

  • Milestone changed from Future Release to 3.5

@lessbloat
5 years ago

#12 in reply to: ↑ 9 @lessbloat
5 years ago

Replying to nacin:

For review from Jane:

I can't speak for Jane, but here are my thoughts:

  • The help text on the Comments screen says "The small bubble with the number in it shows how many comments that post has received." This is not accurate — the bubble shows the number of approved comments only. It is highlighted blue if there are pending comments. What should the new help text say?

Changed it to read, "The small bubble with the number in it shows the number of approved comments that post has received." in 19788.2.diff

  • On the Comments screen, it says "View Post" or "View Page" in the right column. For comments on attachments, should it say "View Attachment"? "View Attachment Page"? "View Attachment Post"?

This appears to already be set in trunk as "View Attachment Page" (line 59 of wp-includes/post.php), which sounds good to me.

#13 @ryan
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [22275]:

Improve the contextual help for the comment bubble in the 'In Response To' column. Props lessbloat. fixes #19788

Note: See TracTickets for help on using tickets.