Media options screen - misunderstanding

[pavelevap]

There is following code in options-media.php:

if ( ! empty( $content_width ) )
	$media_options_help .= ' ' . __( 'If you do not set the maximum embed size, it will be automatically sized to fit into your content area.' );

and

if ( !empty($content_width) ) echo '<br />' . __("If the width value is left blank, embeds will default to the max width of your theme.");

But even if maximum embed size is set (width and height) or not, we are checking $content_width which can be set by theme (for example Twenty Eleven) and not by Maximum embed size values on this screen.

When Twenty Eleven is activated, these two strings are always visible and there is no way how to change width, even if these strings talk about it.

When any other theme is activated (without $content_width), these strings will be never displayed.

I am not sure what is wrong (strings or logic), but it is misleading for users, I guess...

[obenland]

The logic is correct here.

In ​wp_embed_defaults() the embed width overrides all other values ($content_width and default 500px). When $content_width is not set by the Theme, width will either be the setting value or 500px.