WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 20 months ago

Last modified 20 months ago

#19789 closed defect (bug) (invalid)

Media options screen - misunderstanding

Reported by: pavelevap Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3.1
Component: Help/About Keywords:
Focuses: Cc:

Description

There is following code in options-media.php:

if ( ! empty( $content_width ) )
	$media_options_help .= ' ' . __( 'If you do not set the maximum embed size, it will be automatically sized to fit into your content area.' );

and

if ( !empty($content_width) ) echo '<br />' . __("If the width value is left blank, embeds will default to the max width of your theme.");

But even if maximum embed size is set (width and height) or not, we are checking $content_width which can be set by theme (for example Twenty Eleven) and not by Maximum embed size values on this screen.

When Twenty Eleven is activated, these two strings are always visible and there is no way how to change width, even if these strings talk about it.

When any other theme is activated (without $content_width), these strings will be never displayed.

I am not sure what is wrong (strings or logic), but it is misleading for users, I guess...

Change History (2)

comment:1 obenland20 months ago

  • Component changed from General to Administration
  • Resolution set to invalid
  • Status changed from new to closed

The logic is correct here.

In wp_embed_defaults() the embed width overrides all other values ($content_width and default 500px). When $content_width is not set by the Theme, width will either be the setting value or 500px.

comment:2 SergeyBiryukov20 months ago

  • Component changed from Administration to Help/About
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.