Rewrite rules for custom taxonomies not generated as permalinks are switched on

[duck__boy]

The rewrite rules are not being created for any custom taxonomies when you select the 'Postname' structure. You must first select either 'Day and name' or 'Month and name' (but not 'Numeric'), save the permalink structure, and then select 'Postname' and resave.

I think selecting 'Numeric' fails for above method because none of the taxonomy rules are altered at all when you select 'Postname', so the ones that were created by 'Numeric' still start with 'archive/'.

[SergeyBiryukov]

Can't reproduce on a clean install. My steps:

1. Set permalinks to "Post name".
2. Create a custom taxonomy and assign it to a post. I've used ​Genres and Writers example from Codex with a minor adjustment: for standard posts rather than a book post type.
3. Flush rewrite rules by visiting Permalink Settings screen (without changing the structure).
4. The taxonomy archive (e.g. /genre/science-fiction/) is properly displayed.

[duck__boy]

Replying to SergeyBiryukov:

Can't reproduce on a clean install. My steps:

1. Set permalinks to "Post name".
2. Create a custom taxonomy and assign it to a post. I've used ​Genres and Writers example from Codex with a minor adjustment: for standard posts rather than a book post type.
3. Flush rewrite rules by visiting Permalink Settings screen (without changing the structure).
4. The taxonomy archive (e.g. /genre/science-fiction/) is properly displayed.

Have you tried setting the permalinks to 'Default', to remove all rewrite rules, and then setting them back to 'Post name'? To my understanding, when you add a taxonomy the rules are flushed, so your steps would not see an error - it is only when you change the structure after creation.

[dd32]

Can you please do the following?

1. Post an example piece of code to reproduce it (as simple as possible?) - A similar problem happens sometimes when the incorrect hooks are used
2. Does hitting save twice on the permalinks page help?

[SergeyBiryukov]

Replying to duck__boy:

Have you tried setting the permalinks to 'Default', to remove all rewrite rules, and then setting them back to 'Post name'?

Just tried that. Taxonomy archive is only displayed then after saving the changes twice, as dd32 suggested. This seems to be the case for other (non-default) structures too, not just "Post name".

[duck__boy]

Replying to dd32:

Can you please do the following?

1. Post an example piece of code to reproduce it (as simple as possible?) - A similar problem happens sometimes when the incorrect hooks are used
2. Does hitting save twice on the permalinks page help?

I'm unable to post code, as this occurs in the admin panel under permalinks, not through code. And yes, saving it twice does seem to work.

[dd32]

I'm unable to post code, as this occurs in the admin panel under permalinks, not through code. And yes, saving it twice does seem to work.

But your custom taxonomies are added via code correct? It sounds like Sergey has duplicated however.

This sounds exactly like #16736 which was supposed to be fixed in 3.3

[duck__boy]

Replying to dd32:

I'm unable to post code, as this occurs in the admin panel under permalinks, not through code. And yes, saving it twice does seem to work.

But your custom taxonomies are added via code correct? It sounds like Sergey has duplicated however.

This sounds exactly like #16736 which was supposed to be fixed in 3.3

Sorry, yes taxonomies are added via code (register_taxonomy()), but that is not what this issue is about. And yes, sounds similar to the other ticket.

[SergeyBiryukov]

Looks like #16736 wasn't really fixed. [18443] fixed #18040 for CPT, but the similar issue still exists for custom taxonomies.

19794.patch​ implements the same fix for register_taxonomy().

[duck_]

In [19930]:

Taxonomy rewrite generation when turning on permalinks, r18443 for taxonomies. Props SergeyBiryukov. Fixes #19794.