Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#19827 closed defect (bug) (fixed)

remove_help_tab() not working as expected

Reported by: tfnab Owned by:
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3.1
Component: Administration Keywords: has-patch
Focuses: Cc:


remove_help_tab takes $id as a parameter. this is either confusing or wrong. the method does the following:

unset( $this->_help_tabs[ $id ] );

but since add_help_tab simply does this:

$this->_help_tabs[] = $args;

you have to call remove_help_tab with numerical values such as 0, 1, 2 etc. but not the 'this-id' passed in e.g.


in addition if you remove the zero element, initially there is no active tab on the help tab.

fix attached. this makes the following line remove the previously created tab:


Attachments (1)

core-ticket19827.diff (1.5 KB) - added by tfnab 9 years ago.

Download all attachments as: .zip

Change History (2)

#1 @nacin
9 years ago

  • Milestone changed from Awaiting Review to 3.4
  • Resolution set to fixed
  • Status changed from new to closed

I noticed this in #19974 and fixed it in [19944].

Note: See TracTickets for help on using tickets.