wp_localize_script() combines statements improperly

[TobiasBg]

When making multiple calls to wp_localize_script() on the same $handle, the individual JSONified objects are merged together with ;\n ​in this line.
However, each individual var statement has already been correctly terminated by a semicolon ; ​a few lines above.

Due to that, the resulting output has an extra semicolon after each but the last var statement (i.e. ;;).

Removing the semicolon from the string in ​line 151 should fix this.

[azaozz]

Generally having two consecutive semicolons in JS is acceptable (not only at the end of line). Many JS libraries still add a semicolon at the very beginning (when minimized) to prevent concatenation errors.

The second semicolon could be moved to ​L:146 as it matters only when there's 'l10n_print_after' part.

[TobiasBg]

Yes, that's true, as the two semicolons are not causing any issues/warnings/errors. It's just looking weird, and with just one semicolon the code looks cleaner (I feel).

Moving it from line 151 to 146 looks good to me, as the only time when the semicolon could matter would be, if the semicolon at the end of the legacy l10n_print_after is missing.

[TobiasBg]

@tw2113: Thanks for the patch! The moved semicolon should go after the $after variable though, as that variable is the one that we need to "protect" from not having a semicolon. Everything before $after will already have one from line 143.

[tw2113]

Fixed placement of the semicolon

[tw2113]

You're welcome. Fixed with the new diff file.

Replying to TobiasBg:

@tw2113: Thanks for the patch! The moved semicolon should go after the $after variable though, as that variable is the one that we need to "protect" from not having a semicolon. Everything before $after will already have one from line 143.

[azaozz]

In [19832]:

Move an unsightly semicolon to where it belongs in wp_localize_script(), props tw2113, fixes #19830