WordPress.org

Make WordPress Core

Changes between Initial Version and Version 28 of Ticket #19840


Ignore:
Timestamp:
03/25/12 21:51:32 (3 years ago)
Author:
aaroncampbell
Comment:

19840.13.diff​ fixes an issue with the custom headers page. If you let the nonce expire and refreshed on step 2 or 3, it would load step 1. However, since step=2/3 was still in the URL the proper JS wasn't loaded and the "choose from image library" link stopped working.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #19840

    • Property Cc xoodrew@… sabreuse@… georgemamadashvili@… aaroncampbell mpvanwinkle77 scribu ngomau@… added
    • Property Keywords has-patch needs-testing added; needs-patch removed

  • Ticket #19840 – Description

    initial v28  
    1 In a recent version, we made it so uploaded custom header images get saved in the media library. Awesome! Next step: on the custom header and background screens, we need an option to choose an image from the media library. UI-wise, should just be an option next to the select/upload line. Should be implemented on both screens.  
     1In a recent version, we made it so uploaded custom header images get saved in the media library. Awesome! Next step: on the custom header and background screens, we need an option to choose an image from the media library. UI-wise, should just be an option next to the select/upload line. Should be implemented on both screens. The fix was to make `step()` nonce-aware so it could better return the proper step.