WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 18 months ago

#19840 closed task (blessed)

Select custom header or background images from media library — at Version 28

Reported by: jane Owned by:
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3
Component: Media Keywords:
Focuses: Cc:

Description (last modified by aaroncampbell)

In a recent version, we made it so uploaded custom header images get saved in the media library. Awesome! Next step: on the custom header and background screens, we need an option to choose an image from the media library. UI-wise, should just be an option next to the select/upload line. Should be implemented on both screens. The fix was to make step() nonce-aware so it could better return the proper step.

Change History (47)

comment:1 DrewAPicture2 years ago

  • Cc xoodrew@… added

comment:2 sabreuse2 years ago

  • Cc sabreuse@… added

comment:3 Mamaduka2 years ago

  • Cc georgemamadashvili@… added

comment:4 aaroncampbell2 years ago

  • Cc aaroncampbell added

comment:5 mpvanwinkle772 years ago

  • Cc mpvanwinkle77 added

greuben2 years ago

comment:6 greuben2 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

ticket:19840:19840.diff adds the link on custom background page. If the patch is good, will duplicate it for custom header.

comment:7 aaroncampbell2 years ago

Seems to work really well for me. For the header images there will be a little more to do because we'll need to add the meta to keep them listed as headers. I'm also assuming we want to allow the user to crop for headers since a lot of headers will still require fixed dimensions.

@greuben - If you're up for doing the patch though, that sounds great!

comment:8 sabreuse2 years ago

@greuben, thanks for the patch!

The one issue I'm seeing right away is that regardless of the image size I choose in the image library, the background is being set to use the thumbnail size.

I'll also second Aaron's comments about headers -- whatever functionality we currently apply to headers has to also be available for headers from the image library -- it should act exactly the same as choosing any other image for the end user, so we'd have to allow for cropping (including flex sizes), storing as part of the available set for random headers, etc.

greuben2 years ago

comment:9 greuben2 years ago

@aaroncampbell: Yes header images do need a little more coding. Will post a patch for it asap.

@sabreuse: Thanks for the feedback. Check v2.diff, it removes other unnecessary form fields i.e url, title, caption and allows to select right image size

greuben2 years ago

comment:10 greuben2 years ago

v3.diff - patch for both custom background & header.

aaroncampbell2 years ago

comment:11 aaroncampbell2 years ago

The v3 patch didn't work for me at all. I found out it's because the JS in only enqueued/echod if NO_HEADER_TEXT is not defined or is false. Since I had header text turned off I didn't get any of the JS. 19840.2.diff fixes that.

aaroncampbell2 years ago

comment:12 aaroncampbell2 years ago

I talked to @nacin and 19840.3.diff includes his suggestions:

  • Context for the 'or' translation like drag-drop does
  • Instead of adding a second parameter to get_upload_iframe_src() the first parameter now accepts a string or an array.
  • Moved wp_set_background_image() inside the Custom_Background class.

comment:13 sabreuse2 years ago

With the latest patch (and also the previous one, but I wasn't ever able to capture the actual messages), I'm seeing a brief flash of several notices within the thickbox, immediately after clicking "Use as header image" or "Use as background".

Notice: Undefined index: post_title in /var/www/core/wp-admin/includes/media.php on line 489 
Notice: Undefined index: url in /var/www/core/wp-admin/includes/media.php on line 896 
Notice: Undefined index: post_excerpt in /var/www/core/wp-admin/includes/media.php on line 902 
Notice: Undefined index: post_title in /var/www/core/wp-admin/includes/media.php on line 902

Those refer to media_send_to_editor() and image_media_send_to_editor().

Everything after that point works as expected, but I'm not sure of the right approach for the notices - suppress (since they're not actually attributes we need in this case)? Or?

greuben2 years ago

comment:14 greuben2 years ago

19840.4.diff 19840.5.diff fixes the notices.

Last edited 2 years ago by greuben (previous) (diff)

greuben2 years ago

sabreuse2 years ago

Fixes remaining notices

comment:15 sabreuse2 years ago

It looks like my patch crossed paths with @greuben's 19840.5

comment:16 scribu2 years ago

  • Cc scribu added

comment:17 scribu2 years ago

So which patch should we test?

comment:18 greuben2 years ago

Replying to sabreuse:

It looks like my patch crossed paths with @greuben's 19840.5

The two patches differ a little bit

19840.5.diff removes the unwanted filter image_media_send_to_editor()

19840.5.2.diff does sanity checks i.e isset() in image_media_send_to_editor()

aaroncampbell2 years ago

comment:19 aaroncampbell2 years ago

19840.6.diff is based on .5 by @grueben. I like removing the default filter if our filter is handling things, I think it's cleaner. There's really just some code formatting cleanup (Whitespace fixes, etc) and the removal of a couple comments that were clearly for debugging.

comment:20 follow-up: ryan2 years ago

Needs refresh due to [19999]

aaroncampbell2 years ago

comment:21 in reply to: ↑ 20 aaroncampbell2 years ago

Replying to ryan:

Needs refresh due to [19999]

19840.7.diff is refreshed. It moves back to an args array as the parameter, so that other things can be passed in the future.

ryan2 years ago

Another refresh

comment:22 ryan2 years ago

Thickbox has a horizontal scrollbar for me. Do we need the "Edit Image" button?

ryan2 years ago

Screenshot, Choose from image library

ryan2 years ago

Screenshot, Dialog

greuben2 years ago

fix horizontal scroll

greuben2 years ago

comment:23 greuben2 years ago

19840.10.diff - modified the patch based on azaozz's suggestions in IRC.

sabreuse2 years ago

refresh of 19840.10.diff

comment:24 sabreuse2 years ago

19840.11.diff is a refresh of 19840.10 (previous patch didn't apply cleanly after recent changes to /wp-admin/includes/media.php)

Last edited 2 years ago by sabreuse (previous) (diff)

comment:25 sabreuse2 years ago

New issue introduced in 19840.10.diff: after the js changes in this version, choosing a custom background image from the media library correctly updates the background, but tb_remove() fails, and the thickbox remains onscreen with no indication that the bg has been changed.

(I'm also confused about why this script ended up in the set-post-thumbnail.js file -- as I understood the IRC conversation, the point was to no longer override send_to_editor, but sticking it in a file that's not related to backgrounds at all doesn't seem very maintainable. Was that a mistake or am I missing some logic there?)

Confirmed that choosing a background was working as expected as of 19840.9, and that selecting a custom header works as expected in the latest.

comment:26 mau2 years ago

  • Cc ngomau@… added

aaroncampbell2 years ago

comment:27 aaroncampbell2 years ago

19840.12.diff seems to work for me even post-nacin's war on insanity. I agree with @sabreuse that the JS didn't really belong in the set-post-thumbnail.js file, so I added a custom-header.dev.js which makes more sense.

aaroncampbell2 years ago

comment:28 aaroncampbell2 years ago

  • Description modified (diff)

19840.13.diff fixes an issue with the custom headers page. If you let the nonce expire and refreshed on step 2 or 3, it would load step 1. However, since step=2/3 was still in the URL the proper JS wasn't loaded and the "choose from image library" link stopped working.

aaroncampbell2 years ago

Note: See TracTickets for help on using tickets.