Editor API + DFW

[sushkov]

Currently wp_editor() has no out-of-the-box support for DFW

TinyMCE wpfullscreen plugin has to be tweaked and proper CSS/JS files enqueued.

[sushkov]

CSS rules that are required by DFW
​https://github.com/scholarpress/buddypress-courseware/blob/master/static/css/courseware-editor.css

[sushkov]

You can use this plugin to test editors:
​https://gist.github.com/1820220

Before using, run the minifier!

[sushkov]

Titles should not be cached anymore.

[sushkov]

I also updated the gist, if you want to stress-test it.
​https://gist.github.com/1820220

[azaozz]

Refreshed the patch and added some missing parts.

[azaozz]

In [20166]:

Add support for DFW for all instances of the editor, part props sushkov, fixes #19843

[azaozz]

Tested separating the DFW styles in another stylesheet: it doesn't make much difference as when minified and compressed the combined stylesheet is only 1KB larger. Better to have all editor related styles in one stylesheet and avoid the extra request when on the front-end.

[sushkov]

Fair enough.
Thanks.

[nacin]

In [20283]:

Move editor-buttons.css to editor.css to reflect its current use. see #19843.

[nacin]

Via ocean90, plugins that enqueue editor-buttons directly:

slidedeck-lite-for-wordpress/slidedeck.php
rich-text-tags/rich-text-tags.php
marctv-quicktags/marctv_quicktags.php
easy-admin-color-schemes/easy-admin-color-schemes.php
ckeditor-for-wordpress/ckeditor_class.php
background-manager/app/Myatu/WordPress/BackgroundManager/Main.php
advanced-custom-fields/core/fields/wysiwyg.php

Sigh.

[azaozz]

Replying to nacin:

Via ocean90, plugins that enqueue editor-buttons directly...

Ugh, hope we can keep the rename. There is a way to make it back-compat: add a css file with the old name that only has one @import rule at the top and a comment that it's deprecated.

[ocean90]

enqueue editor-buttons directly

Not sure if it's clear, but they are using wp_print_styles / wp_enqueue_style, not directly the files.

So we could handle this in wp_print_styles / wp_enqueue_style. If $handle is editor-buttons set $handle to editor and return a _deprecated_argument message. Should be enough.

[nacin]

The problem also is things like dependencies. If someone specifies 'editor-buttons' as a dependency we'll have to handle the renaming there as well.

We could just rename back the handle and leave the file as editor.dev.css, for now.

[azaozz]

Replying to nacin:

We could just rename back the handle and leave the file as editor.dev.css, for now.

Or perhaps have both handles 'editor-buttons' and 'editor' (pointing to the same file) and trigger a deprecated notice if the first one is used. Or even email the 7 plugins authors and ask them to change the handle name?

[sushkov]

+1 for getting in touch with authors.
All the plugins were updated during last couple of months, so it should not be a problem.

[nacin]

Let's just rename back the handle for 3.4.

[azaozz]

In [20334]:

Rename back the handle for the editor CSS, props nacin, fixes #19843