Opened 13 years ago
Closed 13 years ago
#19853 closed task (blessed) (fixed)
Theme description should be hidden by default and author should be shown
Reported by: | helenyhou | Owned by: | ryan |
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-patch |
Focuses: | Cc: |
Description
As per IRC discussion, the themes screens should mimic the look on .com, hiding the description along with the Details. The theme author should be shown at all times, as it is an important detail.
Difference between installed and search list tables - themes.php
does not hide the details as theme-install.php
does and has slightly different ordering of elements. Thinking that they should be the same.
Attachments (4)
Change History (17)
#2
@
13 years ago
- Keywords has-patch added
19853.diff moves the description into and the author out of the hidden details in theme-install.php
and moves things around on themes.php
to be more similar to the install screen. Could not find the same author name and link in the .org API response, so it's a little different for theme-install.php
, but maybe I missed it.
Screenshot of themes.php
with one expanded: http://cl.ly/45282y440k0310113Q35
Suggestion from Ipstenu and sabreuse is to remove tags from installed theme details entirely.
#3
@
13 years ago
Tags and descriptions. If you've already installed them, you know what they are. Maybe a 'click to expand'?
#5
@
13 years ago
I wouldn't remove altogether, but I'd hide them both in the default view -- the info should be available to be expanded, but if I've already searched for and installed a theme and I'm looking right at the screenshot, I don't need to know that it's white and 2-column.
Another argument for having the description available to be expanded (or viewed somehow) is multisite users who already have a selection of themes in front of them without having gone through the search process themselves. They can filter by tag on the installed set, but they may never have had access to the description.
#6
@
13 years ago
Ah, the description, file path, and tags are hidden by default in my patch on themes.php
. The screenshot just shows one expanded (to show what that looks like and to show where the update notice goes when details are shown).
#8
@
13 years ago
<h3><?php echo $name ?> <span><?php _e('by') ?></strong> <?php echo $author ?></span></h3>
That isn't very translator friendly. Probably need something like:
<h3><?php printf( __('%1$s <span>by %2$s</span>', $name, $author); ?></h3>
Should that closing strong be there?
#10
@
13 years ago
Added patch to delegate for clicks to "details," which is a good practice anyway, but will also make #19815 not break current or new "details" expansion.
#11
@
13 years ago
- Keywords ux-feedback removed
19853.2.diff makes it friendlier for translators. Author is included next to the title in theme-install.php
to keep it shown and parallel themes.php
. Discussed briefly in IRC: https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-01-18&sort=asc#m354703
#12
@
13 years ago
19853.3.diff, with enhancements from nacin and for ryan.
Patch forthcoming, unless I'm beaten to it.