WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19853 closed task (blessed) (fixed)

Theme description should be hidden by default and author should be shown

Reported by: helenyhou Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

As per IRC discussion, the themes screens should mimic the look on .com, hiding the description along with the Details. The theme author should be shown at all times, as it is an important detail.

Difference between installed and search list tables - themes.php does not hide the details as theme-install.php does and has slightly different ordering of elements. Thinking that they should be the same.

Related: #19815 and #19816

Attachments (4)

19853.diff (3.4 KB) - added by helenyhou 2 years ago.
Patch for themes.php and theme-install.php
19853.delegateDetails.diff (461 bytes) - added by DH-Shredder 2 years ago.
Patch to delegate calls for "details" clicks
19853.2.diff (3.4 KB) - added by helenyhou 2 years ago.
19853.3.diff (3.9 KB) - added by helenyhou 2 years ago.
Comment for translators; whitespace all the things

Download all attachments as: .zip

Change History (17)

comment:1 helenyhou2 years ago

Patch forthcoming, unless I'm beaten to it.

helenyhou2 years ago

Patch for themes.php and theme-install.php

comment:2 helenyhou2 years ago

  • Keywords has-patch added

19853.diff moves the description into and the author out of the hidden details in theme-install.php and moves things around on themes.php to be more similar to the install screen. Could not find the same author name and link in the .org API response, so it's a little different for theme-install.php, but maybe I missed it.

Screenshot of themes.php with one expanded: http://cl.ly/45282y440k0310113Q35

Suggestion from Ipstenu and sabreuse is to remove tags from installed theme details entirely.

comment:3 Ipstenu2 years ago

Tags and descriptions. If you've already installed them, you know what they are. Maybe a 'click to expand'?

comment:4 sabreuse2 years ago

  • Cc sabreuse@… added

comment:5 sabreuse2 years ago

I wouldn't remove altogether, but I'd hide them both in the default view -- the info should be available to be expanded, but if I've already searched for and installed a theme and I'm looking right at the screenshot, I don't need to know that it's white and 2-column.

Another argument for having the description available to be expanded (or viewed somehow) is multisite users who already have a selection of themes in front of them without having gone through the search process themselves. They can filter by tag on the installed set, but they may never have had access to the description.

comment:6 helenyhou2 years ago

Ah, the description, file path, and tags are hidden by default in my patch on themes.php. The screenshot just shows one expanded (to show what that looks like and to show where the update notice goes when details are shown).

comment:7 helenyhou2 years ago

  • Keywords ux-feedback added

comment:8 ryan2 years ago

<h3><?php echo $name ?> <span><?php _e('by') ?></strong> <?php echo $author ?></span></h3>

That isn't very translator friendly. Probably need something like:

<h3><?php printf( __('%1$s <span>by %2$s</span>', $name, $author); ?></h3>

Should that closing string be there?

Version 0, edited 2 years ago by ryan (next)

comment:9 DH-Shredder2 years ago

  • Cc mike.schroder@… added

DH-Shredder2 years ago

Patch to delegate calls for "details" clicks

comment:10 DH-Shredder2 years ago

Added patch to delegate for clicks to "details," which is a good practice anyway, but will also make #19815 not break current or new "details" expansion.

helenyhou2 years ago

comment:11 helenyhou2 years ago

  • Keywords ux-feedback removed

19853.2.diff makes it friendlier for translators. Author is included next to the title in theme-install.php to keep it shown and parallel themes.php. Discussed briefly in IRC: https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-01-18&sort=asc#m354703

helenyhou2 years ago

Comment for translators; whitespace all the things

comment:12 helenyhou2 years ago

19853.3.diff, with enhancements from nacin and for ryan.

comment:13 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19840]:

Hide theme details by default. Props helenyhou, DH-Shredder. fixes #19853

Note: See TracTickets for help on using tickets.