Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 11 months ago

#19870 closed enhancement (wontfix)

Update wp-config-sample.php for WP Coding Standards

Reported by: DrewAPicture Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:


Per discussion in #19869 thought maybe we should update wp-config.php spacing to coding standards since suggested Multisite defines already adhere to them.

The salts generator would also need to be updated.

Attachments (1)

19870.diff (2.9 KB) - added by DrewAPicture 4 years ago.

Download all attachments as: .zip

Change History (7)

4 years ago

#1 @DrewAPicture
4 years ago

  • Type changed from defect (bug) to enhancement

#2 @nacin
4 years ago

As would setup-config.php with a regex that works for both whitespace and not.

#3 @nacin
4 years ago

There's also a magic number in setup-config.php: $secret_keys[$k] = substr( $v, 28, 64 );

So we'd also need to bump the salts generator version number.

I'd rather just re-open #19869 and remove the spaces from multisite. We have slightly different standards for user-edited files as it is (for example, line endings), and I'd rather not cause confusion or have extra work done over a few spaces in a define() call.

#4 @DrewAPicture
4 years ago

  • Keywords dev-feedback removed
  • Resolution set to wontfix
  • Status changed from new to closed

#5 @helenyhou
4 years ago

  • Milestone Awaiting Review deleted

#6 @SergeyBiryukov
11 months ago

#30912 was marked as a duplicate.

Note: See TracTickets for help on using tickets.