WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#19872 reopened enhancement

Add Hook/Filter to image_resize_dimensions in media.php

Reported by: webbtj Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.3.1
Component: Media Keywords: 2nd-opinion
Focuses: Cc:

Description

It would be great if a hook, a filter, a global, an option, or something somewhere were created to allow the image_resize_dimensions() function in media.php to resize images to be larger than the original. In a typical scenario I can understand why you would not want to allow this, however there are rare circumstances where this would be helpful (generating a background image). Currently lines 349 and 350 of media.php read:

$new_w = min($dest_w, $orig_w);
$new_h = min($dest_h, $orig_h);

and lines 378 to 380 read:

// if the resulting image would be the same size or larger we don't want to resize it
if ( $new_w >= $orig_w && $new_h >= $orig_h )
	return false;

It would be great if we were provided a boolean to alter these two blocks, for example:

if($allow_resize){
	$new_w = $dest_w;
	$new_h = $dest_h;
}else{
	$new_w = min($dest_w, $orig_w);
	$new_h = min($dest_h, $orig_h);
}

...

// if the resulting image would be the same size or larger we don't want to resize it
if ( $new_w >= $orig_w && $new_h >= $orig_h && !$allow_resize)
	return false;

Change History (2)

comment:1 scribu2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

There already are two hooks in the wp_generate_attachment_metadata() function: 'intermediate_image_sizes_advanced' and 'wp_generate_attachment_metadata'.

They should be enough.

comment:2 scribu2 years ago

  • Component changed from General to Media
  • Keywords 2nd-opinion added
  • Milestone set to Awaiting Review
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Type changed from feature request to enhancement

Sorry, you were obviously talking about something else.

Note: See TracTickets for help on using tickets.