WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#19881 closed enhancement (fixed)

Update imgAreaSelect jQuery plugin

Reported by: ocean90 Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3.1
Component: External Libraries Keywords: has-patch commit
Focuses: Cc:

Description

WordPress includes version 0.9.6 of the imgAreaSelect jQuery plugin.

Current version ist 0.9.8.

(Followed by ticket:17242#comment:29)

Attachments (3)

19881.patch (33.2 KB) - added by ocean90 6 years ago.
19881.2.patch (6.0 KB) - added by ocean90 6 years ago.
Updated CSS file too
19881.2.with-docs.patch (35.4 KB) - added by ocean90 6 years ago.
With docs from http://odyniec.net/projects/imgareaselect/jquery.imgareaselect.dev.js

Download all attachments as: .zip

Change History (10)

@ocean90
6 years ago

#1 @aaroncampbell
6 years ago

Thanks. I'll update my patch on #17242 to pull that out.

#2 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.4

@ocean90
6 years ago

Updated CSS file too

#3 @azaozz
6 years ago

Seems to work properly in our main implementation in the image editor. On the other hand doesn't seem there are improvements or bug fixes that would benefit the implementation, so maybe update it in 3.5?

Don't think the css needs updating. The only change is that it makes the animated borders a little bit stronger (opacity: 0.4 vs. opacity: 0.5).

#4 follow-up: @nacin
6 years ago

In general, if it doesn't hurt and has no effect, we should make an attempt to run the latest version of external libraries. It makes us a better citizen and adds respect/credence to when we ask people to push the Update button.

#5 in reply to: ↑ 4 @azaozz
6 years ago

Replying to nacin:

Agreed. The only concern is whether beta2 isn't too late to add this.

#6 @ryan
6 years ago

  • Keywords commit added

#7 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20602]:

Update jQuery imgAreaSelect plugin to 0.9.8. props ocean90. fixes #19881.

Note: See TracTickets for help on using tickets.