Make WordPress Core

Opened 13 years ago

Last modified 3 years ago

#19885 reopened defect (bug)

Feed wfw Namespace no longer valid

Reported by: ajwagner777's profile ajwagner777 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.3.1
Component: Feeds Keywords: has-patch close
Focuses: Cc:

Description

Related to this post http://wordpress.org/support/topic/rss-feed-wellformedweborg-offline?replies=2

A broken link scan of our website revealed that the link in the feeds to http://wellformedweb.org/CommentAPI/ (for the wfw namespace) is invalid. Going to that website reveals that the site has been taken down by the hosting company.

I found 2 references to that namespace in /wp-includes/feed-rss2.php and /wp-admin/includes/export.php and removed them, and the instances to the wfw namespace within the feed content. This fixed my issue.

This begs the larger question: should this be removed/replaced in the core if the site that references the namespace is no longer available?

Verified here: http://ww2.aaronwagner.net/feed/

Attachments (1)

19885.diff (557 bytes) - added by solarissmoke 13 years ago.
Remove unused wfw namespace from export xml

Download all attachments as: .zip

Change History (8)

#1 @nacin
13 years ago

It's a shame that wellformedweb.org is down, but a namespace URL does not need to resolve. It may look like a URL, but it is just a unique identifier of the namespace. A validating parser would benefit from URL resolution, but that's it.

Not sure why we have wfw referenced in the export, as it is only used in feed-rss2.php for wfw:commentRss. Removing the namespace reference there will result in invalid XML.

#2 in reply to: ↑ description @solarissmoke
13 years ago

  • Keywords has-patch close added

A broken link scan of our website revealed that the link in the feeds to http://wellformedweb.org/CommentAPI/ (for the wfw namespace) is invalid. Going to that website reveals that the site has been taken down by the hosting company.

I think the problem is that your link checker is trying to resolve/visit XML namespace URIs, which it shouldn't?

Patch removes the wfw namespace from the export file (guessing it was copied over by mistake), although presumably there is no harm in leaving it there either.

@solarissmoke
13 years ago

Remove unused wfw namespace from export xml

#3 @wonderboymusic
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Marked close 2 years ago.

#4 @SergeyBiryukov
6 years ago

#47143 was marked as a duplicate.

#5 follow-up: @ramon fincken
3 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

@wonderboymusic this is still present and yes still a 404, why can't we delete this line?

#6 in reply to: ↑ 5 @SergeyBiryukov
3 years ago

  • Milestone set to Awaiting Review

Replying to ramon fincken:

this is still present and yes still a 404, why can't we delete this line?

Just to clarify, is it about the instance in wp-includes/feed-rss2.php or wp-admin/includes/export.php? Removing the former would result in invalid XML, as it's used for wfw:commentRss.

Is there an actual problem solved by removing this line? As explained in comment:1, a namespace URL does not need to resolve. It may look like a URL, but it is just a unique identifier of the namespace.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

#7 @ramon fincken
3 years ago

hmm @SergeyBiryukov I guess you are right.

However .. Can't we point it to something that DOES produce some sensible output for humans?

Note: See TracTickets for help on using tickets.