get_comments_link() doesn't link properly if there are no responses

[cgrymala]

Since the current implementation of get_comments_link() simply returns the permalink with #comments appended to the end of it, and the HTML element with an ID of comments only exists when existing comments are wrapped inside of it, it doesn't lead to anything when there are 0 comments on the post.

I've attached a patch that checks whether there are any comments on the post or not; and, if not, it appends #respond to the end of the link; otherwise it appends #comments.

[cgrymala]

get_comments_link() checks number of comments before generating link

[solarissmoke]

In the bundled themes (and I suspect most other themes as well), #respond is a descendant of #comments anyway, so this wouldn't make any difference?

[cgrymala]

I was going by the code included in wp-includes/theme-compat/comments.php, which uses #comments as an ID for the <h3> tag at the top of the comment list. That <h3> is only output when have_comments() is true (it's not wrapping anything, and doesn't even exist if there are no comments).

I realize that that file is deprecated, but if that's the way WordPress builds the comment area by default, that might be the way a lot of people are using it.

[chriscct7]

Needs refresh because of #19210

[wonderboymusic]

Makes a lot of sense: [attached:19893.diff refreshed]

[wonderboymusic]

In 34075:

Comments: get_comments_link() should return a link with #respond as the hash instead of #comments if get_comments_number() returns 0.

Props cgrymala, wonderboymusic.
Fixes #19893.

[swissspidy]

Looks like Tests_Feed_RSS2::test_items is failing after this change.

Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'http://example.org/?p=27#comments'
+'http://example.org/?p=27#respond'

[netweb]

19893.2.diff fixes the comment link response in Tests_Feed_RSS2::test_items() as there are no comments created for the created posts in this test, therefore per r34075 the comment link to each post in the test should end in #respond and not #comment

[jeremyfelt]

In 34092:

Tests: Update Tests_Feed_RSS::test_items to expect new comment permalink structure.

Introduced in [34075] for posts without comments.

Props netweb.
Fixes #19893.