WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#19899 closed enhancement (fixed)

Redundant logic in filter_SSL() function

Reported by: deltafactory's profile deltafactory Owned by: duck_'s profile duck_
Milestone: 3.4 Priority: normal
Severity: trivial Version: 3.3.1
Component: Multisite Keywords: has-patch commit
Focuses: Cc:

Description

I'm not sure if there's a reason it's written this way, but the logic in this line seems redundant.

​http://core.trac.wordpress.org/browser/trunk/wp-includes/ms-functions.php#L1947

if ( 'http' === $arrURL['scheme'] && 'https' !== $arrURL['scheme'] )

In the interest of simplification, shouldn't this line be:

if ( 'http' === $arrURL['scheme'] )

Attachments (1)

ms-functions.php.patch​ (446 bytes) - added by deltafactory 13 years ago.

Download all attachments as: .zip

Change History (3)

@deltafactory
13 years ago

#1 @scribu
13 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.4

Yes, it is redundant.

#2 @duck_
13 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [19759]:

Remove redundant logic from filter_SSL(). Props deltafactory. Fixes #19899.

Note: See TracTickets for help on using tickets.