Make WordPress Core

Opened 21 years ago

Closed 21 years ago

Last modified 20 years ago

#1991 closed defect (bug) (fixed)

HTML tool in rich editor wreaks havoc on some tables

Reported by: rodm Owned by: ryan
Priority: high Milestone:
Component: General Version: 2.0
Severity: major Keywords: bg|has-patch bg|commit
Cc: Focuses:

Description

Enter a simple table with empty cells into the html editor:

<table>
<tr>
<td></td>
<td></td>
</tr>
</table>

click on the HTML tool in the tool bar. Don't edit anything, but click Update.

Click on the HTML tool again. Some neat new markup gets inserted!

<table border="0"><br />
<tr><br />
<td></td><br />
<td></td><br />
</tr><br />
</table>

Now save the page, and come back and edit it. Click on the HTML tool again. Even more good stuff!

<table border="0">
<tr>
<td>&amp;nbsp;</td>
<td>&amp;nbsp;</td>
</tr>
</table> 

Attachments (1)

tinymce2.diff.gz (75.1 KB ) - added by skeltoac 21 years ago.

Download all attachments as: .zip

Change History (6)

#1 @rodm
21 years ago

  • Summary HTML tool in rich editor wreaks have on some tablesHTML tool in rich editor wreaks havoc on some tables

#2 @skeltoac
21 years ago

  • Milestone2.0
  • Owner changed from anonymous to skeltoac

Pending a little bit more testing, I have this working well on my own system. Had to handle a bug or two in TinyMCE ;-)

#3 @skeltoac
21 years ago

  • Keywords bg|has-patch bg|commit added
  • Owner changed from skeltoac to ryan
  • Priority normalhigh

I added some filtering and source formatting for tables. Table code is now fairly well indented and no longer has tags where they don't belong, as far as I've tested.

Incidentally, this also upgrades TinyMCE to 2.0 Final, which was released two days ago, and uses the source code instead of the compacted javascript. Not many changes in the code, but enough to make it worthwhile, including bug fixes by yours truly. Opera 9 is supposed to work :-D though I haven't tried it.

wp-includes/js/tinymce/tiny_mce_src.js and wp-includes/js/tinymce/plugins/wordpress/editor_plugin_src.js can be deleted if they haven't already.

The attachment is gzipped to fit on Trac. For the original, see http://skeltoac.homelinux.net/tinymce2.diff

#4 @ryan
21 years ago

  • Resolutionfixed
  • Status newclosed

(In [3265]) tinyMCE updates from skeltoac. fixes #1991

#5 @(none)
20 years ago

  • Milestone 2.0

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.