Post shortlink box tied to the wrong post type parameter

[phill_brown]

I think the shortlink box that allows users to edit the post slug should be appear when publicly_queryable is true, not the public parameter.

publicly_queryable sets whether a post type can be requested via URI and overrides public if one set to true and the other to false.

[nacin]

publicly_queryable is designed to control the querying of objects of that post type in the general sense, not individually.

It's phpdoc description is: "Whether post_type queries can be performed from the front page. Defaults to whatever public is set as."

So, example.com/?post_type=tweet will filter and show you tweets as long as the tweet post type has publicly_queryable = true.

Notably, pages are set to false, which means that ?post_type=page will not get you a list of pages.

This played out in #17040.