Opened 13 years ago
Closed 13 years ago
#19923 closed defect (bug) (fixed)
admin colors-*.css needs foreground color in form inputs
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | 3.3.1 |
Component: | UI | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
The colors-fresh style sheet sets the background color of form inputs to white but does not set a foreground color. This leads to problems for people who have non-standard browser preferences. A patch is attached that colors the text black.
Attachments (4)
Change History (17)
#1
@
13 years ago
- Component changed from General to UI
- Keywords has-patch ui-feedback added; form foreground background color removed
#4
@
13 years ago
- Summary changed from colors-fresh needs foreground color in form inputs to admin colors-*.css needs foreground color in form inputs
So ignore the first patch, please.
#7
@
13 years ago
- Owner set to helenyhou
- Status changed from new to reviewing
The first patch also applies to inputs, so some juggling will need to occur here.
#8
@
13 years ago
If using an earlier patch, make sure to apply the same change to both the classic and fresh css files.
#9
@
13 years ago
Further investigation indicates that inputs also ignore the body
's declaration of color and use browser styles instead. Freaking forms. Let's go with #000 for all of the above as per browser default and to keep it simple. New patch for both colors-*.css incoming.
#10
@
13 years ago
Actually ran across a duplicate: #11645. Has similar patch, but specifies colors that won't end up working well for selects in Webkit.
#12
@
13 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Per koop, we should lighten up the foreground color for inputs to match the body, since the background is white. Selects need to stay black, as there's that pesky gray background in Webkit. 19923.2.diff
helenyhou suggested that
#333
would be better than#000
. Please adjust the patch accordingly if deemed more appropriate.