WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19923 closed defect (bug) (fixed)

admin colors-*.css needs foreground color in form inputs

Reported by: convissor Owned by: helenyhou
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3.1
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

The colors-fresh style sheet sets the background color of form inputs to white but does not set a foreground color. This leads to problems for people who have non-standard browser preferences. A patch is attached that colors the text black.

Attachments (4)

wp-colors-fresh-form-color.diff (328 bytes) - added by convissor 2 years ago.
wp--colors-admin-form-color.diff (653 bytes) - added by convissor 2 years ago.
Use 333 as color. Patch colors-classic too.
19923.diff (661 bytes) - added by helenyhou 2 years ago.
19923.2.diff (700 bytes) - added by helenyhou 2 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 SergeyBiryukov2 years ago

  • Component changed from General to UI
  • Keywords has-patch ui-feedback added; form foreground background color removed

comment:2 SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:3 convissor2 years ago

helenyhou suggested that #333 would be better than #000. Please adjust the patch accordingly if deemed more appropriate.

convissor2 years ago

Use 333 as color. Patch colors-classic too.

comment:4 convissor2 years ago

  • Summary changed from colors-fresh needs foreground color in form inputs to admin colors-*.css needs foreground color in form inputs

So ignore the first patch, please.

comment:5 SergeyBiryukov2 years ago

  • Keywords commit added; ui-feedback removed

comment:6 nacin2 years ago

Our select elements currently have #000. Inputs are #333. #333 looks good on the white input background, but #000 looks better on the gray select background. Going with the first patch. UI folks can duke it out in a future release.

comment:7 nacin2 years ago

  • Owner set to helenyhou
  • Status changed from new to reviewing

The first patch also applies to inputs, so some juggling will need to occur here.

comment:8 convissor2 years ago

If using an earlier patch, make sure to apply the same change to both the classic and fresh css files.

comment:9 helenyhou2 years ago

Further investigation indicates that inputs also ignore the body's declaration of color and use browser styles instead. Freaking forms. Let's go with #000 for all of the above as per browser default and to keep it simple. New patch for both colors-*.css incoming.

helenyhou2 years ago

comment:10 helenyhou2 years ago

Actually ran across a duplicate: #11645. Has similar patch, but specifies colors that won't end up working well for selects in Webkit.

comment:11 ryan2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In [20659]:

Set foreground color to #000 for form inputs. Props helenyhou, convissor. fixes #19923

helenyhou2 years ago

comment:12 helenyhou2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Per koop, we should lighten up the foreground color for inputs to match the body, since the background is white. Selects need to stay black, as there's that pesky gray background in Webkit. 19923.2.diff

comment:13 koopersmith2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20748]:

Lighten foreground color for inputs to match the standard body text. Also lighten several other instances of pure black. props helenyhou, fixes #19923.

Note: See TracTickets for help on using tickets.