WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#19935 closed defect (bug) (fixed)

Redundant index in comment table schema

Reported by: westi Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3.1
Component: Database Keywords: early
Focuses: Cc:

Description

From and lost and buried : ​http://core.trac.wordpress.org/ticket/9642#comment:26

A minor improvement for the comments table: the first index is redundant since it is a prefix of the second one. KEY comment_approved (comment_approved), KEY comment_approved_date_gmt (comment_approved,comment_date_gmt),

props dbuser123

We should do this in 3.4 seeing as we are already tweaking db schemas

Attachments (3)

19935.diff​ (1.3 KB) - added by ryan 3 years ago.
19935.2.diff​ (1.7 KB) - added by ryan 3 years ago.
19935.3.diff​ (1.8 KB) - added by ryan 3 years ago.

Download all attachments as: .zip

Change History (4)

@ryan — 3 years ago

@ryan — 3 years ago

@ryan — 3 years ago

comment:1 @ryan — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [19799]:

Drop the comment_approved index from the comments table. comment_approved_date_gmt is sufficient. fixes #19935

Note: See TracTickets for help on using tickets.