is_post_type_archive doesn't work with Tax Query

[wonderboymusic]

same problem as here: #18614

queried_object clobbers the post_type query portion. $this->is_post_type_archive returns true and post_type is attainable from public query vars.

This breaks all over eMusic. as does the other ticket, have to check is_post_type_archive() && 'whatever' === get_query_var( 'post_type' ) vs is_post_type_archive( 'whatever' )

[scribu]

Regarding even-better-patch.diff​, it's debatable: why shouldn't the category be the queried object?

In general, the idea of having a single "queried object" breaks down when you query by more than one criteria.

is-pta-patch.diff​ looks fine.

[scribu]

Actually, is-pta-patch.diff​ doesn't look fine, since in_array() returns a boolean, whereas array_intersect() returns an array.

[nacin]

Incorporated this into the patch on #18614.

[nacin]

Looks like I glanced off of both approaches here, but might not have solved this. Let's consolidate efforts either way in #18614.