WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#19951 closed defect (bug) (duplicate)

incorrect use of self and $this simultaneously

Reported by: diddledani's profile diddledani Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.3.1
Component: Administration Keywords:
Focuses: Cc:

Description

the following code around line 704 of wp-admin/includes/screen.php appears to be incorrect, using both self:: and $this-> simultaneously. This shouldn't work afaict, and doesn't when using the stricter (than zend) hiphop-php runtime. 

<?php if ( $has_sidebar ) : ?>
<div class="contextual-help-sidebar">
        <?php echo self::$this->_help_sidebar; ?>
</div>
<?php endif; ?>

Change History (3)

#1 @scribu
14 years ago

  • Milestone changed from Awaiting Review to 3.4
  • Resolution set to fixed
  • Severity changed from normal to minor
  • Status changed from new to closed

[19680]

Last edited 14 years ago by scribu (previous) (diff)

#2 @ocean90
14 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#3 @ocean90
14 years ago

  • Milestone 3.4 deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

#19746

Note: See TracTickets for help on using tickets.