WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#19955 closed defect (bug) (fixed)

Update wordpress-logo.png and logo-login.png

Reported by: nacin Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: UI Keywords:
Focuses: Cc:

Description

These are essentially the same graphic. We should consider combining them, unless there is a valid reason to keep the colors different.

wordpress-logo.png

http://core.trac.wordpress.org/export/19823/trunk/wp-admin/images/wordpress-logo.png

logo-login.png

http://core.trac.wordpress.org/export/19823/trunk/wp-admin/images/logo-login.png

Attachments (3)

logo-login.png (4.9 KB) - added by iammattthomas 4 years ago.
Atoning for my past color sins.
19955.1.patch (1.1 KB) - added by edward mindreantre 4 years ago.
Removed references to logo-login. Kept it in the $_old_files array, though.
readme.html.diff (531 bytes) - added by soulseekah 4 years ago.
"Hey! I need some room to breathe here..."

Download all attachments as: .zip

Change History (14)

comment:1 @nacin4 years ago

logo-login.php is much newer. It should be copied over wordpress-logo.png and all references to it removed, using wordpress-logo.png as the canonical image.

@iammattthomas4 years ago

Atoning for my past color sins.

@edward mindreantre4 years ago

Removed references to logo-login. Kept it in the $_old_files array, though.

comment:2 @edward mindreantre4 years ago

  • Cc edward@… added
  1. Move the logo-login.png to wordpress-logo.png
  1. Apply the patch.

comment:3 @nacin4 years ago

In [19937]:

Update login-logo.png to use proper color. Copy it over wordpress-logo.png. Make that one canonical, and stop using login-logo.png. Leave it for plugins. props iammattthomas. see #19955.

comment:4 @nacin4 years ago

In [19938]:

Remove old logo-login.gif from manifest. props edward mindreantre, see #19955.

comment:5 @nacin4 years ago

As logo-login.gif was ruthlessly deleted from #17324 and no one complained, I'm going to go ahead and remove logo-login.png here. I did a grep of the plugins repo, and the only plugin that would be affected would be this one, which moves replacement headers into wp-admin/images...

comment:6 @nacin4 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19940]:

Remove unused logo-login.png after all. fixes #19955.

comment:7 @soulseekah4 years ago

The new logo is 5px shorter and 14px wider! The readme.html file squished it up to 250x68. I propose to remove the inline attributes. Will check all instances of wordpress-logo.png shortly, may not fit nicely somewhere else as well.

@soulseekah4 years ago

"Hey! I need some room to breathe here..."

comment:8 @soulseekah4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 follow-up: @soulseekah4 years ago

Sorry, don't know whether to reopen or create a new ticket and list this ticket as related. Decided to go for less tickets.

comment:10 in reply to: ↑ 9 @nacin4 years ago

Replying to soulseekah:

Sorry, don't know whether to reopen or create a new ticket and list this ticket as related. Decided to go for less tickets.

For simple things like this, when it is closed on a milestone that is not yet completed, this is fine.

comment:11 @nacin3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20624]:

Remove img width/height from the readme.html WP logo. props soulseekah. fixes #19955. see #20293 for any follow-ups.

Note: See TracTickets for help on using tickets.