Self-created config file allows invalid table prefix

[rmarks]

It's possible to manually create a wp-config.php file with an empty table prefix. This will create the tables and possible work okay as a standalone install, but this causes problems in Multisite.

[rmarks]

Attached is a patch that will abort the install if there is an empty table prefix.

[SergeyBiryukov]

Related: #19566

[nacin]

So we don't tank existing installs, this should only prevent it on install.php.

Good idea though.

[kurtpayne]

Should the prefix also be run through strtolower()? Related #19748

[SergeyBiryukov]

Replying to nacin:

So we don't tank existing installs, this should only prevent it on install.php.

19970.2.diff​ is the patch for install.php. Also adds some whitespace as per coding standards.

Replying to kurtpayne:

Should the prefix also be run through strtolower()? Related #19748

I guess we should remove strtolower() in #19748.

[nacin]

Per bug scrub last week, ryan and I were cool with this.

[nacin]

In [20699]:

Issue an error during the WordPress install process if wp-config.php is configured with an empty database table prefix, which is not supported.

props SergeyBiryukov.
fixes #19970.

[nacin]

In [20700]:

A more resilient check for the base table prefix. see #19970.