WP_Screen help getter functions missing

[npetetin]

Please add getter functions in WP_Screen for help tab and sidebar:

public function get_help_tab( $id ) {
	return $this->_help_tabs[ $id ];
}
public function get_help_sidebar() {
	return $this->_help_sidebar;
}

Thanks.

[BenChapman]

Added getters to wp-admin/includes/screen.php

[nacin]

When looking through this, I noticed that $id isn't actually used to key _help_tabs. (Note it's also _help_tabs, not _help_tab.) This is lame and is something we can get away with breaking compatibility on.

Attached, I'm adding get_help_tab(), get_help_tabs(), and get_help_sidebar(), and then using those helper methods elsewhere in the class.

[nacin]

Simple tests: ​http://unit-tests.trac.wordpress.org/changeset/547

[nacin]

In [19944]:

Add WP_Screen methods get_help_tabs(), get_help_tab( $id ), get_help_sidebar(). Store help tabs by tab ID, not numeric key; allows proper removal with remove_help_tab( $id ). props BenChapman, npetetin for initial getter patch. fixes #19974.

[npetetin]

Great!
Thanks.

[nacin]

In [19950]:

Add an @return. fixes #19974.