WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 months ago

#19980 closed defect (bug) (wontfix)

Localized oEmbed providers

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description

Follow-up from #19601.

Some localizations might want to add their own oEmbed provider, perhaps a service widely used by users in their country or those who speak their language, despite us never hearing of it.

Right now, Bulgarian and Chinese add some, and Russian would consider it. ref Others, if shown the opportunity, will also likely want to add some.

We need to come up with a decent solution for handling these. Perhaps it is a switch() on get_locale() in WP_oEmbed.

Change History (6)

comment:1 @dd324 years ago

Do we really need to support them for certain locale's only?

If the service is of a non-spammy nature that's useful to one set of users, perhaps we should enable it globally and consistently support it instead.

comment:2 @nacin4 years ago

If the service is of a non-spammy nature that's useful to one set of users, perhaps we should enable it globally and consistently support it instead.

Agreed. The only reason why I'd want to limit it is to keep the processing time to a minimum, but you're definitely right.

comment:3 @nacin4 years ago

Bulgarian adds #http://(www\.)?vbox7\.com/play:.+# to point to http://vbox7.com/etc/oembed/. Chinese (China) adds three manual regular expressions: http://i18n.trac.wordpress.org/browser/zh_CN/tags/3.3.1/dist/wp-content/languages/zh_CN.php#L302. No word on whether any support oEmbed, but we shouldn't be carrying over any non-oEmbed providers.

comment:4 @SergeyBiryukov3 years ago

I was considering adding three video services for ru_RU. Turned out none of them support oEmbed.

comment:5 @nacin3 years ago

  • Milestone changed from 3.4 to Future Release

The only one with an oEmbed provider is bg_BG and they haven't even done a release since 3.2.1. Punting.

comment:6 @chriscct74 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree with Sergey on this. If an oembed service is in core it should be enabled globally. Given no one has needed a service limited to a locale in the last 3 years, closing as wontfix

Note: See TracTickets for help on using tickets.