Removing a featured image breaks the ability to set a featured image

[batmoo]

Repro steps:

• Create a new post
• Upload an image and set it as the featured image
• Click on "Remove featured image"
• Click on "Add featured image"
• The Gallery tab isn't shown. Neither is the "Set featured image" for any uploaded images.

Problem is that in wp_ajax_set_post_thumbnail, the $post_ID variable isn't globalized, which _wp_post_thumbnail_html expects.

Related to the ajax re-org #15327 -- other things are possibly broken as well.

[batmoo]

Patch globalizes $post_ID in the wp_ajax_set_post_thumbnail context.

[ryan]

Hmmm, how about a post ID arg for _wp_post_thumbnail_html() ?

[ryan]

Pass post id. Untested.

[ryan]

In [19902]:

Add post ID argument to _wp_post_thumbnail_html() rather than relying on a global. Post the ID from wp_ajax_set_post_thumbnail(). Props batmoo. fixes #20003

[batmoo]

Much better fix. Thanks.

[tott]

Pass post_id to get_upload_iframe_src()

[tott]

The post_id needs to be passed to get_upload_iframe_src() as well. See attached patch as proposal.

[ryan]

In [19999]:

Pass post id to get_upload_iframe_src() instead of relying on a global. Props tott. fixes #20003