Make WordPress Core

Opened 12 years ago

Closed 20 months ago

#20007 closed enhancement (maybelater)

Add options & UI for admin registration and password reset notifications

Reported by: veraxus's profile Veraxus Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4
Component: Administration Keywords: has-patch needs-refresh changes-requested
Focuses: Cc:

Description

This patch adds an single checkbox option to WordPress's Settings > Discussion page, allowing users to quickly toggle new user registration notifications/emails on or off.

While the notification function is currently pluggable, allowing non-technical users to easily toggle this feature themselves is both intuitively simple, and should prove generally advantageous to the community.

Attachments (4)

WPRegisterNotificationsOption.diff (240.6 KB) - added by Veraxus 12 years ago.
Diff with minor changes to: /wp-admin/options-discussion.php, /wp-admin/options.php, /wp-includes/pluggable.php, and /wp-admin/includes/schema.php
wp-reg-notify-option-patch.diff (3.8 KB) - added by Veraxus 12 years ago.
Patch that adds registration notification option to WP (svn diff)
wp-reg-notify-option-patch2.diff (5.0 KB) - added by Veraxus 12 years ago.
This patch includes everything from the previous wp-reg-notify-option-patch.diff patch but also adds an option for controlling whether or not admins want to be notified of password resets.
admin-notifications-4.4.patch (4.6 KB) - added by Veraxus 8 years ago.
Adds options for admins to toggle admin notifications for new user and password resets.

Download all attachments as: .zip

Change History (24)

@Veraxus
12 years ago

Diff with minor changes to: /wp-admin/options-discussion.php, /wp-admin/options.php, /wp-includes/pluggable.php, and /wp-admin/includes/schema.php

#1 @Veraxus
12 years ago

Only minor changes are needed to include this functionality. The following four files are affected:

/wp-admin/options-discussion.php
/wp-admin/options.php
/wp-includes/pluggable.php
/wp-admin/includes/schema.php

Last edited 12 years ago by Veraxus (previous) (diff)

#2 @nprasath002
12 years ago

Hi veraxus.
Could upload the patch in the correct format???
i couldnt track the changes

Last edited 12 years ago by nprasath002 (previous) (diff)

#3 @SergeyBiryukov
12 years ago

  • Keywords has-patch removed

#4 @Veraxus
12 years ago

Whoops. New patch incoming.

@Veraxus
12 years ago

Patch that adds registration notification option to WP (svn diff)

#5 @Veraxus
12 years ago

  • Keywords has-patch added

@Veraxus
12 years ago

This patch includes everything from the previous wp-reg-notify-option-patch.diff patch but also adds an option for controlling whether or not admins want to be notified of password resets.

#6 @Veraxus
12 years ago

  • Version set to 3.4

Any chance this could make it into 3.4 beta 3? The changes are programmatically very minor and well tested (I've been using this tweak on dozens of production sites for months), but the usability improvements are substantial.

If needed, I can submit an updated patch based on the latest 3.4 trunk.

#7 @SergeyBiryukov
12 years ago

  • Keywords ux-feedback added

#8 @bryceadams123
11 years ago

Could this be put into 3.5? It's a very useful patch.

#9 @knutsp
11 years ago

  • Cc knut@… added

#10 @SergeyBiryukov
10 years ago

#25904 was marked as a duplicate.

#12 @jeremyfelt
10 years ago

  • Focuses ui added

#13 @chriscct7
8 years ago

  • Focuses ui removed
  • Keywords has-patch ux-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Given this is now the default way users get their passwords, this is no longer a good idea. Closing as wontfix

#14 @Veraxus
8 years ago

  • Keywords needs-refresh added
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Summary changed from Add option for new user registration notifications to Add options & UI for admin registration and password reset notifications

@chriscct7 - this targets admin emails only, not emails to users. WordPress still generates massive amounts of useless trash mail to admins as a result of user registrations and password resets, with no simple core UI to disable it. These are notifications that most admins and site owners do not need to receive. I've been using a pluginized version of this fix for years and, honestly, it should have been merged into core years ago.

Reopening and refreshing patch.

Last edited 8 years ago by Veraxus (previous) (diff)

#15 @SergeyBiryukov
8 years ago

  • Milestone set to Awaiting Review

@Veraxus
8 years ago

Adds options for admins to toggle admin notifications for new user and password resets.

#16 @Veraxus
8 years ago

Patch updated for current 4.4 trunk. Allows admins to enable/disable admin notification emails for new user registrations and password resets. Again, this does not affect any emails or notifications to users - this is for admin notices only.

This feature is long overdue, let's get it done in 4.4!

#17 @Veraxus
8 years ago

  • Keywords has-patch added; needs-refresh removed

#18 @chriscct7
8 years ago

  • Keywords needs-testing needs-screenshots added

This ticket was mentioned in Slack in #core by veraxus. View the logs.


8 years ago

#20 @desrosj
20 months ago

  • Keywords needs-refresh changes-requested added; needs-testing needs-screenshots removed
  • Resolution set to maybelater
  • Status changed from reopened to closed

I'm going to close this out as a maybelater.

While it's a valid request, it doesn't seem like a good change when evaluated against the project's philosophies. The lack of activity on this ticket in the last 10 years also is telling that it's not something that's in high demand.

Since this ticket was created, the code related to sending these emails has been updated to use an action hook instead of being called directly (see [34107] and [34251] from #33587). It's now much easier to disable these emails:

remove_action( 'after_password_reset', 'wp_password_change_notification' );
remove_action( 'register_new_user', 'wp_send_new_user_notifications' );

If this were to be reopened, the patch would need to be updated to reflect these changes.

Note: See TracTickets for help on using tickets.