WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20018 closed defect (bug) (fixed)

Typo in new wptexturize() pattern

Reported by: danielbachhuber Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Formatting Keywords:
Focuses: Cc:

Description

In r19795, the following:

$dynamic[ '/\'([\s.]|\Z)/' ] = $closing_single_quote . '$2'; // closing single quote

should instead be:

$dynamic[ '/\'([\s.]|\Z)/' ] = $closing_single_quote . '$1'; // closing single quote

The former removes the space from after the new pretty single quote

Change History (4)

comment:1 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19907]:

Use correct reference in regex. props danielbachhuber, fixes #20018.

comment:2 nacin2 years ago

Nice catch, thanks.

comment:3 SergeyBiryukov2 years ago

  • Component changed from General to Formatting
  • Milestone changed from Awaiting Review to 3.4

comment:4 nacin2 years ago

Everything passed the unit tests after r19795, but the ones that maintained whitespace were not tested for that. I added http://unit-tests.trac.wordpress.org/changeset/526, which fails before [19907] and passes now.

Note: See TracTickets for help on using tickets.