Opened 13 years ago
Closed 13 years ago
#20039 closed defect (bug) (fixed)
parse_query attempts to assign a non-variable by reference
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Query | Keywords: | has-patch |
Focuses: | Cc: |
Description
Line 1628 of query.php is currently:
$this->queried_object =& get_page_by_path($qv['pagename']);
This results in a PHP error of "Only variables should be assigned by reference", pulling the result of the get_page_by_path into a variable and referencing that works okay, but i'm not confident enough in that not breaking other things to submit it as a patch!
$path = get_page_by_path($qv['pagename']); $this->queried_object =& $path;
Attachments (1)
Change History (6)
Note: See
TracTickets for help on using
tickets.
Related: http://lists.automattic.com/pipermail/wp-hackers/2010-October/035615.html, [16104], [18541].
So either the suggested fix or put back
$null = null
would probably do it.Do we actually need
=&
any more?