WP_User missing magic __unset() method

[johnjamesjacoby]

When the magic methods were put into WP_User in 3.3, __unset() was skipped. This has the result of unset( $user_data->$foo ); not actually doing anything.

Patched against r19926.

[scribu]

Well, since we have __set(), I guess it's fair to have __unset() too.

[ryan]

What, no unit tests? ;-)

[ryan]

In here would work: ​http://unit-tests.trac.wordpress.org/browser/wp-testcase/test_user.php#L140

[kurtpayne]

Ask and ye shall receive ​[UT618]

[johnjamesjacoby]

Patch and unit test. Moving into 3.6 for consideration.

[nacin]

I'm fine with this, but what's the use case? Other than a change in behavior from a year ago. I'm curious because I'm not sure we should easily allow the unsetting of core properties if we can avoid it. (Doesn't matter, just playing devil's advocate.)

[MikeHansenMe]

see #30284

[wonderboymusic]

refreshed/combined - not entirely sure how necessary this is

[wonderboymusic]

In 34380:

Users: add __unset to WP_User.

Adds unit tests.

Props johnjamesjacoby, MikeHansenMe, wonderboymusic.
Fixes #20043.

[DrewAPicture]

• Needs an access-modifier
• Needs complete docs

[DrewAPicture]

In 34390:

Docs: Add a missing access modifier to the declaration for the WP_User::__unset() magic method, introduced in [34380].

Also adds missing documentation to the DocBlock.

Fixes #20043.

[boonebgorges]

[34380] is causing errors in the test_user_unset_uppercase_id() test introduced in the same changeset. What's happening is this:

• __unset() unsets $user->ID
• The test then attempts to access $user->ID. Since the property no longer exists (! isset( $user->ID )), the magic __get() kicks in.
• __get() tries to get_user_meta( $this->ID, 'ID', true ). But $this->ID is an undefined property.

Unsetting an object property like ID is going to cause similar problems through core and elsewhere. Either we should have a blacklist of properties that cannot be unset (so unset( $user->ID ) would return false), or unset( $user->ID ) should just empty the property ($user->ID = 0).

[tyxla]

WP_User::unset(): blacklisting ID so it can't be unset; setting it to 0 instead.

[wonderboymusic]

In 34466:

Users: in WP_User::__unset(), don't reset the deprecated prop id to ID. Still throw the deprecated notice.

Update unit test.

Fixes #20043.