Don't use $title as var name if it's in global context

[ocean90]

In admin-header.php we declare $title as a global variable. $title should be used for setting up the title of the page.

In wp-admin/themes.php line 240 we are using $title as a variable name, but not for setting up the title.

A result of this is, that get_admin_page_title() can return a wrong title. (In this case a broken theme name.)

[koopersmith]

In [19941]:

Don't unintentionally override the global variable. props ocean90, see #20062.

[nacin]

Let's consider reducing our reliance on $title. Perhaps introduce set_admin_page_title( $title = null ), where if null it returns the set value. Then we take a $title and set it in admin-header, and use it inside get_admin_page_title(). Kills reliance on the global (while we could still set it up, if we wanted).

[koopersmith]

I left the ticket open because this is a more general issue — $title is an especially ambiguous name to give a global variable. Nacin, you just beat me to the rest of my comment.

If we decide to fix these instances as they pop up, feel free to close the ticket as fixed.

[nacin]

Our dependence on $title will have to wait.