WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 5 years ago

#20066 closed enhancement (maybelater)

SImplify the functionality of script_concat_settings() and remove the globals

Reported by: azaozz Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Script Loader Keywords: needs-patch
Focuses: Cc:

Description

As discussed in the comments on #20055, script_concat_settings() should be split into couple of simple functions that only check the constants and the 'can_compress_scripts' server option.

Change History (6)

#1 @azaozz
8 years ago

There's an initial patch by ericlewis: http://core.trac.wordpress.org/attachment/ticket/20055/20055-3.patch

Not sure what the best back-compat option is here. Outright removing the globals would break plugins that use them. Seems we should move script_concat_settings() to deprecated.php and trigger the appropriate "deprecated" messages.

Then we can introduce simplified function that would return whether compression from PHP is supported by the server using CONCATENATE_SCRIPTS, COMPRESS_SCRIPTS and get_site_option('can_compress_scripts').

#2 @ericlewis
8 years ago

  • Cc eric.andrew.lewis@… added

#3 @azaozz
8 years ago

  • Milestone changed from 3.4 to Future Release

This didn't make it in 3.4.

#4 @jeremyfelt
7 years ago

Hunting around what compression_test() actually does and impacts drove me crazy today. Is there still interest in cleaning this up?

#5 @nacin
6 years ago

  • Component changed from General to Script Loader

#6 @chriscct7
5 years ago

  • Keywords needs-patch added
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 3 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch).

Note: See TracTickets for help on using tickets.