Opened 13 years ago
Closed 9 years ago
#20066 closed enhancement (maybelater)
SImplify the functionality of script_concat_settings() and remove the globals
Reported by: | azaozz | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Script Loader | Keywords: | needs-patch |
Focuses: | Cc: |
Description
As discussed in the comments on #20055, script_concat_settings() should be split into couple of simple functions that only check the constants and the 'can_compress_scripts' server option.
Change History (6)
#4
@
11 years ago
Hunting around what compression_test()
actually does and impacts drove me crazy today. Is there still interest in cleaning this up?
#6
@
9 years ago
- Keywords needs-patch added
- Milestone Future Release deleted
- Resolution set to maybelater
- Status changed from new to closed
Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 3 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch).
Note: See
TracTickets for help on using
tickets.
There's an initial patch by ericlewis: http://core.trac.wordpress.org/attachment/ticket/20055/20055-3.patch
Not sure what the best back-compat option is here. Outright removing the globals would break plugins that use them. Seems we should move
script_concat_settings()
to deprecated.php and trigger the appropriate "deprecated" messages.Then we can introduce simplified function that would return whether compression from PHP is supported by the server using
CONCATENATE_SCRIPTS
,COMPRESS_SCRIPTS
andget_site_option('can_compress_scripts')
.