WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #20069, comment 10


Ignore:
Timestamp:
09/12/2013 04:39:08 AM (12 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #20069, comment 10

    initial v1  
    55The only issue i can see is if `fileperms()` returns incorrectly.. in which case, part of me wants to suggest that we should at least OR it with 0640 (R/W by owner, R by group), such as done in attachment:20069.2.diff
    66
    7 (note: attachment:20069.diff is missing a bracket in the 2nd case, so it'll fatal with that patch)
     7(note: attachment:20069.diff is missing a bracket in the 2nd case, so it'll fatal with that patch, The extra brackets in the define value are also unneeded, `fileperms() & 0777 | 0640` works as expected)