Can't edit themes with '&' in the name

[trepmal]

If a theme has an ampersand in the name, it cannot be edited through the WordPress theme editor. I tested with a simple child theme:

/*
Theme Name: Amper & Sand
Template: twentyeleven
*/

(doesn't matter if the ampersand is encoded or not)

If that theme is chosen from the 'Select theme to edit' select box, you are presented with The requested theme does not exist. (via wp_die())

Or worse, if it is the active theme you can't even access the Theme Editor, as you are immediately presented with the same message.

[kurtpayne]

I tested this. I can confirm the problem and the patch works.

[trepmal]

Problem returned (see #20103). Patch no longer works. #blamenacin

[nacin]

The theme editor needs to be rewritten to use wp_get_themes() instead of get_themes(), which will change it from being keyed by theme name to by stylesheet. This will fix this.

[kurtpayne]

Tested this without the patch on 3.4-beta1. Cannot reproduce. Looks like the wp_get_themes() rewrite fixed it.

[nacin]

Yes, this is definitely fixed.

[kawauso]

Related/duplicate (slightly broader): #16507