WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20091 closed enhancement (maybelater)

Introduce set_theme_mods function

Reported by: ocean90 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch close
Focuses: Cc:

Description

In core we have get_theme_mod(s) and remove_theme_mod(s) but only set_theme_mod.

We should introduce set_theme_mods too.

(We need this for Gandalf.)

Attachments (1)

20091.patch​ (623 bytes) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (5)

ocean90 — 2 years ago

comment:1 ocean90 — 2 years ago

20091.patch​ props koopersmith.

comment:2 nacin — 2 years ago

We don't have these kinds of setters anywhere else -- update_options(), set_transients(), update_post_metas(), etc. Why not just loop?

comment:3 ocean90 — 2 years ago

  • Keywords close added

We should leave the method internally in WP_Cutomize, but setting it to private/protected.

comment:4 nacin — 2 years ago

  • Milestone 3.4 deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Customize no longer uses this function, so I'm not sure how relevant it is. If Customize does need it, let's just keep it there for now and make sure it is protected. Otherwise, we should remove it.

Note: See TracTickets for help on using tickets.