WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#20096 closed enhancement (fixed)

Use native TinyMCE popup for the image properties dialog

Reported by: azaozz Owned by: azaozz
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords:
Focuses: Cc:

Description

As the title, the native TinyMCE dialogs are better managed than thickbox and have extra features like being movable, resizable, etc.

Attachments (1)

close-mce-popups.patch​ (753 bytes) - added by azaozz 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19977]:

Use native TinyMCE popup for the image properties dialog, fixes #20096, see #20094

#2 @mdawaffe
5 years ago

With thickbox dialogs, you can click outside of them and they go away. That is not the case with the TinyMCE dialog in [19977].

#3 @azaozz
5 years ago

Right but this one works better when MCE is on the front-end. We may be able to hack it to close when clicking the background too :)

#4 follow-up: @mdawaffe
5 years ago

Not saying it's better or worse. Just pointing out a UI inconsistency.

@azaozz
5 years ago

#5 in reply to: ↑ 4 @azaozz
5 years ago

Replying to mdawaffe:

...Just pointing out a UI inconsistency.

Right, the "close on clicking the background" is a Thickbox thing, MCE's popups never had that. Seems easy enough to add it though, patch attached (may need a bit more testing).

Version 0, edited 5 years ago by azaozz (next)
Note: See TracTickets for help on using tickets.