Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#20099 closed enhancement (fixed)

Multisite: Show broken themes in network admin (too)

Reported by: ocean90's profile ocean90 Owned by: nacin's profile nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Themes Keywords: has-patch
Focuses: Cc:


If we want to inform super admins about a broken theme we should do it right.

At the moment it's only displayed on wp-admin/themes.php, also if the theme isn't activated for the site and where a super admin probably won't take a look.

Attachments (1)

20099.patch (2.7 KB) - added by ocean90 12 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ocean90
12 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 3.4
  • Owner set to nacin
  • Status changed from new to assigned
  • Version set to 3.4

See [20151] and #20103.

12 years ago

#2 follow-up: @ocean90
12 years ago

  • Keywords has-patch added

Enable/Disable actions shouldn't be available.

See 20099.patch

#3 in reply to: ↑ 2 @nacin
12 years ago

Replying to ocean90:

Enable/Disable actions shouldn't be available.

I thought about that. But let's say a broken theme was enabled before it was broken, and they want to disable it before fixing it. Unless we are to automatically 'disable' themes when you hit the broken themes page, it's easier to just leave the links. It is pretty evident that the theme is omitted because it is broken.

That said, because I kept broken themes excluded from 'all', searching doesn't work. Not sure how exactly to fix that.

#4 @nacin
12 years ago

Going to prevent enabling but allow disabling and include broken themes in search results.

#5 @nacin
12 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [20160]:

Don't show the Network Enable link for broken themes. Include broken themes in searching on network/themes.php. fixes #20099, see #20103.

Note: See TracTickets for help on using tickets.