Inconsistent menu visibility for Mobile Safari devices

[johnbillion]

When using a device running Mobile Safari the 'Add New' menu under 'Media' is not shown (as iOS devices typically can't upload files). However this is the only place this menu is hidden. This menu is still shown in the admin toolbar and the 'Add New' link is still shown in the Media Library.

[johnbillion]

Patch

[nacin]

$is_iphone also detects some other mobile safari devices, some of which (like android) might have the capability to upload files. We should probably improve $is_iphone's detection.

[johnbillion]

Replying to nacin:

$is_iphone also detects some other mobile safari devices, some of which (like android) might have the capability to upload files. We should probably improve $is_iphone's detection.

I agree. This was the most simple fix.

[SergeyBiryukov]

Sorry I didn't search for existing tickets before opening #20405.

Some mobile devices indeed have the capability to upload files. With wp_is_mobile(), the check isn't limited to Safari. Since [20417], it's no longer possible to upload files using Opera Mini on Windows Mobile.

I guess we can use this ticket to improve iPhone/iPad detection.

[johnbillion]

Closing this as a dupe of #20405 as the issue has been addressed with a patch and a changeset there.

I've opened #20410 to address improvements to device capability detection.