Can't use 'show_admin_bar' filter with conditional tags

[scribu]

I'm trying to show the admin bar only on the front page:

function scribu_show_admin_bar() {
  return is_front_page();
}

add_filter( 'show_admin_bar', 'scribu_show_admin_bar' );

However, this doesn't work because '_wp_admin_bar_init' is called on 'init', before the main WP_Query is set up.

[scribu]

I also tried this variation:

function scribu_show_admin_bar() {
  return !did_action( 'template_redirect' ) || is_front_page();
}

which almost worked: I got the blank space mentioned in #16249

[nacin]

I could go for this.

I'd be curious what will break in doing this. (Surely it will be something...)

[scribu]

​http://nooooooooooooooo.com/

[helenyhou]

​http://thentestiiiiiiiiiitandprovenothingbreaks.com/ :)

[scribu]

I'm afraid this doesn't amend itself well to unit testing, so I could wax poetical about it all day, or we could just give it a soak in trunk and revert it if it breaks a lot of stuff.

[scribu]

I'm bluffing; I can't write verbosely to save my life, but it does seem like a pretty low risk fix.

[helenyhou]

I personally would be happy enough with you saying you tried running the patch yourself for a little while and didn't see anything weird with any of your fancy themes or complicated plugins like bbPress or BuddyPress :)

[scribu]

I just tried it with the latest version of BuddyPress and, interestingly enough, it works.

It also works fine in bbPress, as expected.

[helenyhou]

I can be reasonable. You can hash it out over actually getting it committed, though.

[nacin]

I still have a bad taste in my mouth after #20161, which caused some (limited) grief for plugins, and actually caused enough issues on WordPress.com (because of some toolbar items they add) that they just reverted the change. I do think it is a good change, but let's do this early 3.6. (Seriously — the day we branch, someone hold me to it.)

[nacin]

In 23512:

Move admin bar initialization from init to template_redirect, so conditional tags may be used in the show_admin_bar filter. props scribu. fixes #20101.

[ryan]

This broke some things on wordpress.com. We've reverted it for now. I'll investigate whether what we are doing that triggers the problem is a remotely sane thing to do. :-) Meanwhile, I'll reopen this as a reminder.

[nacin]

If I recall correctly, WordPress.com never bothered to move things out of the footer to begin with (after #20161). So there is likely a plugin somewhere that removed the filter you shouldn't remove and added it back. This is what broke, I imagine.

[ocean90]

Status?