Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#20102 closed enhancement (fixed)

https oEmbed

Reported by: gluten's profile gluten Owned by: ryan's profile ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.3.1
Component: Embeds Keywords: has-patch commit
Focuses: Cc:

Description

The new version of vimeo.com uses https urls, which currently do not trigger WordPress's oEmbed embedding.

Attachments (4)

vimeo-oembed-https.diff (1.1 KB) - added by gluten 12 years ago.
vimeo-oembed-https.2.diff (1.1 KB) - added by johnjamesjacoby 12 years ago.
Patch was stale. Refreshed for whitespace. (wcgr)
vimeo-oembed-https.3.diff (4.6 KB) - added by johnjamesjacoby 12 years ago.
Massaged to handle https/http for all providers
vimeo-oembed-https.4.diff (4.5 KB) - added by johnjamesjacoby 12 years ago.
Cleans up version 3 logic (wcgr)

Download all attachments as: .zip

Change History (20)

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.4

#2 @SergeyBiryukov
12 years ago

  • Component changed from General to Embeds

#3 @ocean90
12 years ago

  • Milestone changed from 3.4 to Awaiting Review

Same problem as with YouTube https embed, see #18719.

#4 @Mamaduka
12 years ago

  • Cc georgemamadashvili@… added

#5 @yoavf
12 years ago

  • Cc yoavf added

#6 @yoavf
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#7 @hd-J
12 years ago

  • Cc jeremy@… added

#8 @nacin
12 years ago

I feel like oEmbed in WordPress should automatically handle https links for all providers, including those that are not regular expressions (http://example.com/*).

@johnjamesjacoby
12 years ago

Patch was stale. Refreshed for whitespace. (wcgr)

#9 @bradparbs
12 years ago

Applied JJJ's patch, works! Rock on WCGR! Props JJJ and Mark Jaquith!

#10 @Tyrun
12 years ago

Applied JJJ's patch as well and it works. Thanks for showing us how @ WCGR!

@johnjamesjacoby
12 years ago

Massaged to handle https/http for all providers

#11 @johnjamesjacoby
12 years ago

vimeo-oembed-https.3.diff updates all the regular expressions to handle https. Updates the simple URL processor to handle https in the regular expression it generates. Props WCGR.

@johnjamesjacoby
12 years ago

Cleans up version 3 logic (wcgr)

#12 @nacin
12 years ago

  • Keywords commit added

Looks good.

#13 @simonwheatley
12 years ago

  • Cc simon@… added

Always nice to see someone has already created the patch you were about to create. :)

#14 @nacin
12 years ago

  • Summary changed from Vimeo https oEmbed to https oEmbed

#15 @ryan
12 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21915]:

Handle https for all oembed providers. Props johnjamesjacoby, gluten. fixes #20102

#16 @camiloclc
12 years ago

youtu.be also seems to accept https, although it redirects to the http version when accessed via browser.

Last edited 12 years ago by camiloclc (previous) (diff)
Note: See TracTickets for help on using tickets.