WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#20102 closed enhancement (fixed)

https oEmbed

Reported by: gluten Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.3.1
Component: Embeds Keywords: has-patch commit
Focuses: Cc:

Description

The new version of vimeo.com uses https urls, which currently do not trigger WordPress's oEmbed embedding.

Attachments (4)

vimeo-oembed-https.diff (1.1 KB) - added by gluten 3 years ago.
vimeo-oembed-https.2.diff (1.1 KB) - added by johnjamesjacoby 3 years ago.
Patch was stale. Refreshed for whitespace. (wcgr)
vimeo-oembed-https.3.diff (4.6 KB) - added by johnjamesjacoby 3 years ago.
Massaged to handle https/http for all providers
vimeo-oembed-https.4.diff (4.5 KB) - added by johnjamesjacoby 3 years ago.
Cleans up version 3 logic (wcgr)

Download all attachments as: .zip

Change History (20)

@gluten3 years ago

comment:1 @SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:2 @SergeyBiryukov3 years ago

  • Component changed from General to Embeds

comment:3 @ocean903 years ago

  • Milestone changed from 3.4 to Awaiting Review

Same problem as with YouTube https embed, see #18719.

comment:4 @Mamaduka3 years ago

  • Cc georgemamadashvili@… added

comment:5 @yoavf3 years ago

  • Cc yoavf added

comment:6 @yoavf3 years ago

  • Milestone changed from Awaiting Review to 3.5

comment:7 @hd-J3 years ago

  • Cc jeremy@… added

comment:8 @nacin3 years ago

I feel like oEmbed in WordPress should automatically handle https links for all providers, including those that are not regular expressions (http://example.com/*).

@johnjamesjacoby3 years ago

Patch was stale. Refreshed for whitespace. (wcgr)

comment:9 @bradparbs3 years ago

Applied JJJ's patch, works! Rock on WCGR! Props JJJ and Mark Jaquith!

comment:10 @Tyrun3 years ago

Applied JJJ's patch as well and it works. Thanks for showing us how @ WCGR!

@johnjamesjacoby3 years ago

Massaged to handle https/http for all providers

comment:11 @johnjamesjacoby3 years ago

vimeo-oembed-https.3.diff updates all the regular expressions to handle https. Updates the simple URL processor to handle https in the regular expression it generates. Props WCGR.

@johnjamesjacoby3 years ago

Cleans up version 3 logic (wcgr)

comment:12 @nacin2 years ago

  • Keywords commit added

Looks good.

comment:13 @simonwheatley2 years ago

  • Cc simon@… added

Always nice to see someone has already created the patch you were about to create. :)

comment:14 @nacin2 years ago

  • Summary changed from Vimeo https oEmbed to https oEmbed

comment:15 @ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21915]:

Handle https for all oembed providers. Props johnjamesjacoby, gluten. fixes #20102

comment:16 @camiloclc2 years ago

youtu.be also seems to accept https, although it redirects to the http version when accessed via browser.

Last edited 2 years ago by camiloclc (previous) (diff)
Note: See TracTickets for help on using tickets.