WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 8 months ago

Last modified 8 months ago

#20107 closed enhancement (maybelater)

Add Filter for user_name length in ms user signup

Reported by: hughwillfayle Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Multisite Keywords:
Focuses: Cc:

Description

It is difficult for us to explain our clients why they cannot have usernames with 3 chars and left. For that issue I'd like to recommend a filter for that, so we can change this with a plugin.

Attachments (1)

ms-functions.diff (898 bytes) - added by hughwillfayle 2 years ago.
Diff for #20107

Download all attachments as: .zip

Change History (9)

hughwillfayle2 years ago

Diff for #20107

comment:1 follow-up: scribu2 years ago

The wpmu_validate_user_signup() function has some restrictions that aren't present when a user registers on a single-site install, so maybe we should just get rid of them.

comment:2 hughwillfayle2 years ago

Should I work on some more diffs?

comment:3 scribu2 years ago

  • Keywords needs-testing removed

No, we should hear from a core dev first.

comment:4 hughwillfayle2 years ago

I hope that there will be a response before the freeze. Thanks for you feedback :)

comment:5 nacin2 years ago

We should probably figure out a way for all of the issues in wpmu_validate_user_signup() to be filtered en masse. This is not the first problem here.

The reason for this restriction is in subdomain situations, keeping it above three letters allows a namespace for datacenters, country/locale codes, etc. Lots of services have a minimum letter requirement.

comment:6 hughwillfayle2 years ago

@nacin: I know that lots of services have restrictions in this field. But I think, that it would be great to let the service-provider let the choice for that. So yes, we should not approve my patch and create another one, which is able to filter all the posted values to filter. I'm going to write a new patch for that and will add it here.

comment:7 jeremyfelt8 months ago

  • Keywords has-patch dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Closing for the same reasons as #20176. Unless we're ready to discuss this further, wpmu_validate_user_signup is available to re-validate user signup.

comment:8 in reply to: ↑ 1 SergeyBiryukov8 months ago

Replying to scribu:

The wpmu_validate_user_signup() function has some restrictions that aren't present when a user registers on a single-site install, so maybe we should just get rid of them.

Related: #17904

Note: See TracTickets for help on using tickets.