WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#20113 closed defect (bug) (fixed)

Remove extra trailing double quote from metabox contextual help tabs

Reported by: niallkennedy Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Validation Keywords: has-patch
Focuses: Cc:

Description

The admin contextual help menu sets an "active" class for a single list item. If active there is a string ' class="active"' added to the element, else empty string.

The markup for the contextual help tabs includes an extra trailing double quote at the end of the opening <li>, creating bad markup.

Patch removes that single character since the id and class attributes are already properly enclosed in double quotes.

Attachments (1)

screen.diff​ (556 bytes) - added by niallkennedy 3 years ago.
remove trailing double quote

Download all attachments as: .zip

Change History (3)

@niallkennedy — 3 years ago

remove trailing double quote

comment:1 @nacin — 3 years ago

  • Milestone changed from Awaiting Review to 3.4

My bad in [19944]. Thanks!

comment:2 @nacin — 3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19987]:

Remove out-of-place double quote. props niallkennedy. fixes #20113.

Note: See TracTickets for help on using tickets.