Make WordPress Core

Opened 9 years ago

Last modified 12 months ago

#20114 new defect (bug)

Posts and Pages w. private visibility don't show up in existing content

Reported by: heinrichgeps Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.3.1
Component: Editor Keywords: needs-refresh 2nd-opinion
Focuses: Cc:


when inserting or editing a link in the editor (post or page) pages & posts with private visibility don't show up in the "existing content" section of the "insert/edit link" popup. All pages/posts with public visibility are shown. This doesn't make sense as I have all necessary privileges to see and edit these private pages/post. Even the admin doesn't see the private pages. Very annoying.

Attachments (1)

20114.diff (1.3 KB) - added by soulseekah 9 years ago.

Download all attachments as: .zip

Change History (11)

#1 @heinrichgeps
9 years ago

  • Severity changed from normal to major

9 years ago

#2 @soulseekah
9 years ago

Remember that links to private content that a visitor has no access to will result in a 404. http://codex.wordpress.org/Content_Visibility#Private_Content
This is especially true for crawlers, you will get 404 even though your content exists for you.

For possible non-core-based solutions to this refer to:

The attached diff shows private posts in the lists. Patch will not work on 3.3.1, since many things have been moved around in that area.

JS would require proper localization for the word "Private" if this enhancement/defect is considered. If not, use HTML links.

#3 @soulseekah
9 years ago

  • Keywords has-patch added; needs-patch removed

#4 @heinrichgeps
9 years ago

The patch works flawless on 3.3.1.

Remember: there are situations where you have only a few pages / posts that are visible to the public and the main content is visible only to subscribers (we love privacy in germany!). It is very annoying not to be able to use the internal link tool. The 404 problem is very well documented with many possible solutions (you pointed to the most important ones).

Ergo: I'd highly propose the implementation of this patch.

#5 @chriscct7
6 years ago

  • Keywords needs-refresh added; has-patch removed

#6 @chriscct7
5 years ago

  • Severity changed from major to normal

#7 @ocean90
2 years ago

#44069 was marked as a duplicate.

#8 @MaximeCulea
2 years ago

Linking a private content might be confusing for a visitor and/or for crawlers considering that this links would generate 404 errors.

So, for my point of view there is no sense in linking a private content.
Finally, as there is a filter, you could programmatically change this behaviour for your needs.

#9 @MaximeCulea
12 months ago

  • Keywords 2nd-opinion added

In my opinion we should not change this behaviour for ux and seo purpose.
Waiting a 2nd opinion since 8 years before taking any decision here.

#10 @knutsp
12 months ago

Would be nice if such items get marked as having a private destination and can be hidden by CSS for visitors or users missing required capability.

Links pointing to 404 is very bad for SEO.

Note: See TracTickets for help on using tickets.