Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#20120 closed enhancement (duplicate)

Space before slash to close BR

Reported by: bananastalktome's profile bananastalktome Owned by:
Milestone: Priority: normal
Severity: trivial Version: 3.4
Component: Formatting Keywords:
Focuses: Cc:

Description

Kind of a petty, I admit, but I noticed http://codex.wordpress.org/WordPress_Coding_Standards shows this as the standard, and I figured I'd help out by checking if any such occurrences exist (using the following):

find -name '*.php' -type f | xargs egrep -n "<br\/>"

Diff attached (my first)...but I won't have my feelings hurt if the ticket is closed and I am banned from trac :)

Attachments (1)

br-spaces.diff (9.0 KB) - added by bananastalktome 13 years ago.

Download all attachments as: .zip

Change History (3)

#1 @GaryJ
13 years ago

The W3C document that WP CS guideline was written 12 years ago - I've been trying to find out a definitive list of the "older browsers" are that everyone refers to when saying the space is needed for their compatibility.

If, as some say, it's for Netscape Navigator (4), and earlier, then the space could probably be dropped.

I've even tweeted at Hixie and Eliot Graff (author of the HTML-XHTML Polyglot document to see if they have a list.

I think it may end up with finding someone with an afternoon free who can install old versions of all the browsers and a simple test page to determine which browsers don't display <br/> correctly.

#2 @SergeyBiryukov
12 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Closing for the same reason as #25075.

Note: See TracTickets for help on using tickets.