WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#20123 closed defect (bug) (fixed)

"Approve" should not be a bulk action when viewing spam comments

Reported by: nacin Owned by: russellwwest
Milestone: 3.4 Priority: normal
Severity: major Version:
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

Approve, Quick Edit, and Edit action links are all hidden on edit-comments.php?comment_status=spam. The only action links are Not Spam and Delete Permanently. These are both bulk actions, but there is also an Approve bulk action.

No word on whether it works. Probably does. It should be removed for consistency, given that Restore simply returns it to the queue.

On the Trash view, there is no Approve bulk action, only Restore and Delete Permanently.

Attachments (1)

class-wp-comments-list-table.php.diff (749 bytes) - added by russellwwest 2 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 in reply to: ↑ description solarissmoke2 years ago

Replying to nacin:

No word on whether it works. Probably does. It should be removed for consistency, given that Restore simply returns it to the queue.

Not always - the result of hitting "Not Spam" depends on what the comment status was before it was marked as spam (using _wp_trash_meta_status).

This means that doing a bulk action of "Not Spam" can cause those comments to end up in different places (approved or pending). Maybe that's why the "Approve" action is also there? (On reflection, this doesn't make too much sense to me. I do think it's counter-intuitive that the result of hitting "Not Spam" is variable.)

Last edited 2 years ago by solarissmoke (previous) (diff)

comment:2 russellwwest2 years ago

  • Owner set to russellwwest
  • Status changed from new to accepted

comment:3 russellwwest2 years ago

  • Keywords has-patch added

comment:4 imshashank2 years ago

  • Severity changed from normal to major

the patch is working fine.... tested and verified..

comment:5 ramiy2 years ago

Related: #17275

comment:6 duck_2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [20533]:

Remove "Approve" bulk action when viewing spam comments as it isn't shown in the row actions. Props russellwwest. Fixes #20123.

Note: See TracTickets for help on using tickets.