WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 13 months ago

#20130 closed enhancement (wontfix)

Remove redundant link_updated code related to bookmarks

Reported by: solarissmoke Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.3.1
Component: General Keywords: has-patch dev-feedback
Focuses: Cc:

Description

The links table has a column called link_updated which used to be used to store the date the link last changed (using pingomatic to check for this).

The link update checking was removed from core some time ago, see #12437, [13744] (also #4230, #4231). However there's still some code in wp-admin/bookmark.php and wp-admin/bookmark-template.php which uses link_updated as well as the links_recently_updated_time option. I guess the column in the database can't just be dropped because of back compat. But the code that uses it in core looks like it can.

Attachments (1)

20130.diff (10.5 KB) - added by solarissmoke 3 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 @solarissmoke3 years ago

  • Type changed from defect (bug) to enhancement

Actually there are quite a few related options lurking in the database:

'links_updated_date_format' => __('F j, Y g:i a'),
'links_recently_updated_prepend' => '<em>',
'links_recently_updated_append' => '</em>',
'links_recently_updated_time' => 120,

@solarissmoke3 years ago

comment:2 @solarissmoke3 years ago

  • Keywords has-patch dev-feedback added

Patch attached, lots of red. This will probably break plugins that were using those options. A quick search says there are very few, although this isn't necessarily a good enough reason to drop them.

comment:3 @johnbillion13 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing in favour of #21307. The links table won't be seeing any fixes like this now.

Note: See TracTickets for help on using tickets.