WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20131 closed defect (bug) (fixed)

Make proper use of the cached jQuery collection in Twenty Twelve's navigation.js

Reported by: mattwiebe Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The brand new navigation.js in twentytwelve fails to use the cached $("#masthead') jQuery collection properly. It's attempting to wrap an already cached jQuery collection inside a new jQuery object several times (which works, because jQuery anticipated this incorrect usage). This patch fixes that.

Or, OMG IAN YOU'RE DOING IT WRONG! :P

Attachments (1)

cached-selector.diff (1.6 KB) - added by mattwiebe 2 years ago.

Download all attachments as: .zip

Change History (7)

mattwiebe2 years ago

comment:1 nacin2 years ago

  • Milestone changed from Awaiting Review to 3.4

Or, OMG IAN YOU'RE DOING IT WRONG! :P

Not unusual. ;)

comment:2 iandstewart2 years ago

This is my new favorite ticket. It beats the heading ticket hands down.

comment:3 lancewillett2 years ago

I lol'd.

comment:4 lancewillett2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

( In [20017] Twenty Twelve: make proper use of the cached jQuery collection in navigation.js, props mattwiebe. Fixes #20131. )

comment:5 mattwiebe2 years ago

Heh. amusement is so much better when it's amusement at Ian's expense.

comment:6 nacin2 years ago

  • Milestone 3.4 deleted
Note: See TracTickets for help on using tickets.