Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#20131 closed defect (bug) (fixed)

Make proper use of the cached jQuery collection in Twenty Twelve's navigation.js

Reported by:	mattwiebe	Owned by:
Priority:	normal	Milestone:
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

The brand new navigation.js in twentytwelve fails to use the cached $("#masthead') jQuery collection properly. It's attempting to wrap an already cached jQuery collection inside a new jQuery object several times (which works, because jQuery anticipated this incorrect usage). This patch fixes that.

Or, OMG IAN YOU'RE DOING IT WRONG! :P

Attachments (1)

cached-selector.diff (1.6 KB ) - added by mattwiebe 14 years ago.

Download all attachments as: .zip

Change History (7)

@mattwiebe
14 years ago

Attachment cached-selector.diff added

#1 @nacin
14 years ago

Milestone Awaiting Review → 3.4

Or, OMG IAN YOU'RE DOING IT WRONG! :P

Not unusual. ;)

#2 @iandstewart
14 years ago

This is my new favorite ticket. It beats the heading ticket hands down.

#3 @lancewillett
14 years ago

I lol'd.

#4 @lancewillett
14 years ago

Resolution → fixed
Status new → closed

( In [20017] Twenty Twelve: make proper use of the cached jQuery collection in navigation.js, props mattwiebe. Fixes #20131. )

#5 @mattwiebe
14 years ago

Heh. amusement is so much better when it's amusement at Ian's expense.

#6 @nacin
14 years ago

Milestone 3.4

Note: See TracTickets for help on using tickets.

Download in other formats: