Remove Tags listing from Manage Themes

[mikeschroder]

Tags are listed under "Manage Themes" (currently installed), both for your current theme, and other themes installed (after clicking on "Details", with respect to 3.4).

Since they're generally only useful during a search for a theme, it's proposed that they be removed from view, as they are already not visible after a search in "Install Themes."

I ran this by Jane, and she agreed with the change.

[mikeschroder]

Remove tags listing and extra <br> between tags/"Available Themes"

[mikeschroder]

20147.diff​ removes the tags from "Manage Themes" -- both from the current theme, and available themes listings.
Also removed a <br>, since the remaining margin between the theme options and "Available Themes" text was significant after removing tags.

[mikeschroder]

Details expanded before patch

[mikeschroder]

Details expanded after patch

[mikeschroder]

No Spacing Removed -- only Tags removed.

[mikeschroder]

Tags and additional spacing removed; Available Themes moved to left of Search.

[mikeschroder]

Added preview imaged and additional options to choose from, in case the spacing isn't liked.

With input from mattfelten, created 20147.3.diff​, which I prefer, and you can see previewed in 20147.3.jpg​.

[nacin]

Available Themes should still come before search in the source. I fiddled with this last week and a simple float plus change of the top margin of the h3 was enough to line things up. Perhaps <h3 class="available-themes"> then with the slightest bit of styling...

[mikeschroder]

Align "Available Themes" header with search box via styles, rather than moving it below search.

[mikeschroder]

Attached 20147.4.diff​, which aligns the "Available Themes" header with the search box via styles, rather than moving it below search.

Looks like the three options for styling this header include assigning a new ID or class, moving it inside the search-form form, or wrapping all available themes "stuff" in a div.

Smallest change would be the ID (along with proper clear on the form), as in 20147.4.diff​, but if making "current theme" and "available theme" stuff enclosed in divs is acceptable, that seems a bit cleaner.

Any preferences?

[nacin]

In [20064]:

Line up elements on themes.php. Line up 'Available Themes' header and search/feature form. Switch to padding instead of margin for #current-theme to prevent margin-uncollapse jitters when animating the feature filter. Move 'Current Theme' inside #current-theme so it is hidden by the feature filter. see #20147.

[nacin]

In [20065]:

Remove theme tags from the themes.php UI. They just take up room and are redundant with the feature filter. The installer already does not show tags. props DH-Shredder, fixes #20147.

[nacin]

In [20067]:

Remove inline styles for 'Apply Filters' feature filter button. Don't <small> the 'Close filters' text. see #20147.

[helenyhou]

Looks like we need a little clearing action on #availablethemes in the case of no results found, lest this happens. 20147.5.diff​

[nacin]

In [20069]:

Use correct name for feature filter REQUEST data to ensure that the search/filter form is present when a filter is active. see #20147.