WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#20147 closed enhancement (fixed)

Remove Tags listing from Manage Themes

Reported by: mikeschroder Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: minor Version: 3.3
Component: Themes Keywords: has-patch ui-feedback
Focuses: Cc:

Description

Tags are listed under "Manage Themes" (currently installed), both for your current theme, and other themes installed (after clicking on "Details", with respect to 3.4).

Since they're generally only useful during a search for a theme, it's proposed that they be removed from view, as they are already not visible after a search in "Install Themes."

I ran this by Jane, and she agreed with the change.

Attachments (10)

20147.diff (1.2 KB) - added by mikeschroder 6 years ago.
Remove tags listing and extra <br> between tags/"Available Themes"
details-with-tags.jpg (115.2 KB) - added by mikeschroder 6 years ago.
Details expanded before patch
details-no-tags.jpg (82.9 KB) - added by mikeschroder 6 years ago.
Details expanded after patch
20147.2.diff (1.1 KB) - added by mikeschroder 6 years ago.
No Spacing Removed -- only Tags removed.
20147.2.jpg (174.8 KB) - added by mikeschroder 6 years ago.
20147.3.diff (2.3 KB) - added by mikeschroder 6 years ago.
Tags and additional spacing removed; Available Themes moved to left of Search.
20147.3.jpg (185.6 KB) - added by mikeschroder 6 years ago.
20147.4.diff (2.3 KB) - added by mikeschroder 6 years ago.
Align "Available Themes" header with search box via styles, rather than moving it below search.
20147.5.diff (356 bytes) - added by helenyhou 6 years ago.
availablethemes.png (6.1 KB) - added by helenyhou 6 years ago.

Download all attachments as: .zip

Change History (21)

@mikeschroder
6 years ago

Remove tags listing and extra <br> between tags/"Available Themes"

#1 @mikeschroder
6 years ago

20147.diff removes the tags from "Manage Themes" -- both from the current theme, and available themes listings.
Also removed a <br>, since the remaining margin between the theme options and "Available Themes" text was significant after removing tags.

@mikeschroder
6 years ago

Details expanded before patch

@mikeschroder
6 years ago

Details expanded after patch

@mikeschroder
6 years ago

No Spacing Removed -- only Tags removed.

@mikeschroder
6 years ago

@mikeschroder
6 years ago

Tags and additional spacing removed; Available Themes moved to left of Search.

@mikeschroder
6 years ago

#2 @mikeschroder
6 years ago

  • Keywords ui-feedback added

Added preview imaged and additional options to choose from, in case the spacing isn't liked.

With input from mattfelten, created 20147.3.diff, which I prefer, and you can see previewed in 20147.3.jpg.

#3 @pavelevap
6 years ago

  • Cc pavelevap@… added

#4 @nacin
6 years ago

Available Themes should still come before search in the source. I fiddled with this last week and a simple float plus change of the top margin of the h3 was enough to line things up. Perhaps <h3 class="available-themes"> then with the slightest bit of styling...

@mikeschroder
6 years ago

Align "Available Themes" header with search box via styles, rather than moving it below search.

#5 @mikeschroder
6 years ago

Attached 20147.4.diff, which aligns the "Available Themes" header with the search box via styles, rather than moving it below search.

Looks like the three options for styling this header include assigning a new ID or class, moving it inside the search-form form, or wrapping all available themes "stuff" in a div.

Smallest change would be the ID (along with proper clear on the form), as in 20147.4.diff, but if making "current theme" and "available theme" stuff enclosed in divs is acceptable, that seems a bit cleaner.

Any preferences?

#6 @nacin
6 years ago

In [20064]:

Line up elements on themes.php. Line up 'Available Themes' header and search/feature form. Switch to padding instead of margin for #current-theme to prevent margin-uncollapse jitters when animating the feature filter. Move 'Current Theme' inside #current-theme so it is hidden by the feature filter. see #20147.

#7 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20065]:

Remove theme tags from the themes.php UI. They just take up room and are redundant with the feature filter. The installer already does not show tags. props DH-Shredder, fixes #20147.

#8 @nacin
6 years ago

In [20067]:

Remove inline styles for 'Apply Filters' feature filter button. Don't <small> the 'Close filters' text. see #20147.

@helenyhou
6 years ago

#9 @helenyhou
6 years ago

Looks like we need a little clearing action on #availablethemes in the case of no results found, lest this happens. 20147.5.diff

http://core.trac.wordpress.org/raw-attachment/ticket/20147/availablethemes.png

#10 @nacin
6 years ago

In [20069]:

Use correct name for feature filter REQUEST data to ensure that the search/filter form is present when a filter is active. see #20147.

#11 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.4
Note: See TracTickets for help on using tickets.